Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boost] update to 1.80.0 #26233

Merged
merged 17 commits into from
Aug 25, 2022
Merged

[boost] update to 1.80.0 #26233

merged 17 commits into from
Aug 25, 2022

Conversation

yurybura
Copy link
Contributor

@yurybura yurybura commented Aug 8, 2022

This PR updates Boost to v1.80.0.

Fixes #26282

@Neumann-A
Copy link
Contributor

Switch to the CMake build? As far as I could tell 1.80 finally comes with proper CMake scripts which install -config.cmake etc.

@yurybura
Copy link
Contributor Author

yurybura commented Aug 8, 2022

Switch to the CMake build? As far as I could tell 1.80 finally comes with proper CMake scripts which install -config.cmake etc.

@Neumann-A
Could you provide details? Release notes don't contain this information yet.

@Neumann-A
Copy link
Contributor

Could you provide details? Release notes doesn't contain this information yet.

hmm ok maybe I was just looking at one of the boost modules and it looked like proper CMake. Looked at program_options and it didn't have what I saw the last time so it might still be partial. So just ignore my ramblings.

@Cheney-W Cheney-W self-assigned this Aug 8, 2022
@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Aug 9, 2022
github-actions[bot]
github-actions bot previously approved these changes Aug 9, 2022
github-actions[bot]
github-actions bot previously approved these changes Aug 10, 2022
@Neumann-A
Copy link
Contributor

ah please consider including/fixing #26004/#22762 (comment)

@yurybura
Copy link
Contributor Author

ah please consider including/fixing #26004/#22762 (comment)

I think it is better to fix this issue in a separate MR. Did you report the issue in Boost.Log?

@Neumann-A
Copy link
Contributor

That is boostorg/log#177 but it is really a bug in the vcpkg boost setup not carrying required dependencies between boost ports.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for boost-modular-build-helper have changed but the version was not updated
version: 1.80.0
old SHA: 1a7242fb169601ee34360a5074f4a698bfcb6526
new SHA: ff6608277a0d5acbac4016cba85b6b65d0ef5b77
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Aug 15, 2022
@yurybura yurybura marked this pull request as ready for review August 16, 2022 09:22
github-actions[bot]
github-actions bot previously approved these changes Aug 19, 2022
@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Aug 24, 2022
@JavierMatosD
Copy link
Contributor

Thank you!

@JavierMatosD JavierMatosD merged commit 8424da5 into microsoft:master Aug 25, 2022
@yurybura yurybura deleted the boost-1.80.0 branch June 26, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[boost] update to 1.80
5 participants