Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][kf5globalaccel] Fix build on windows when x11 is around #26564

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

m-kuhn
Copy link
Contributor

@m-kuhn m-kuhn commented Aug 28, 2022

Describe the pull request

github-actions[bot]
github-actions bot previously approved these changes Aug 28, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/kf5globalaccel/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Aug 28, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/kf5globalaccel/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/kf5globalaccel/vcpkg.json

Valid values for the license field can be found in the documentation

@FrankXie05 FrankXie05 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Aug 29, 2022
@JackBoosY JackBoosY changed the title [kf5globalaccel] Fix build on windows when x11 is around [vcpkg baseline][kf5globalaccel] Fix build on windows when x11 is around Aug 29, 2022
@FrankXie05 FrankXie05 added category:port-bug The issue is with a library, which is something the port should already support and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Aug 29, 2022
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JavierMatosD indicated that the disable is controlling:

https://github.com/KDE/kglobalaccel/blob/master/CMakeLists.txt#L71

which is ... extremely cursed. But given that it has that behavior, this resolves the problem without needing patches, so LGTM

@JavierMatosD
Copy link
Contributor

Thanks!

@JavierMatosD JavierMatosD merged commit c0b6d35 into microsoft:master Sep 1, 2022
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Sep 1, 2022
[kf5globalaccel] Fix build on windows when x11 is around (microsoft#26564)
@m-kuhn m-kuhn deleted the kf5globalaccel branch September 1, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants