-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LuaBridge3] Add new port #26600
[LuaBridge3] Add new port #26600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
Use the version scheme "version" instead of "version-string" in port "luabridge3".
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout f688b2e29676bfa3a02ead4b7096c589f8af8180 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 8132c08..31d37be 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4436,6 +4436,10 @@
"baseline": "2.6",
"port-version": 1
},
+ "luabridge3": {
+ "baseline": "3.0",
+ "port-version": 1
+ },
"luafilesystem": {
"baseline": "1.8.0",
"port-version": 2
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/luabridge3/vcpkg.json
Valid values for the license field can be found in the documentation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Frank <65999885+FrankXie05@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for luabridge3 have changed but the version was not updated
version: 3.0
old SHA: ba41037e81a7c49c91b4e4b3790b05f4b90d8fe1
new SHA: dd80281c8374393b107f109a12cec975477ec088
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
Pinging @kunitoki for response. Is work still being done for this PR? |
Yes sorry, was not sure what i had to do. Will look into it tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for luabridge3 have changed but the version was not updated
version: 3.0
old SHA: ba41037e81a7c49c91b4e4b3790b05f4b90d8fe1
new SHA: 16439874b9efc941d7611d37c3b33f43bb39f7f9
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
@kunitoki Would you mind if I fix this PR for you? :) |
Sure go on |
@kunitoki Any other suggestions for this PR? :) |
I've made a new release, shall i update the hash and version ? btw can the version be changed to |
b6c8609
I obviously broke it 😭 |
@kunitoki According to our policy, we prefer stable releases to beta versions. Unless the beta version specifically states that it is stable. :) |
It's more of a rc than a beta, but it is more stable and secure than the vanilla LuaBridge. It's also being tested with ASAN and UBSAN and produces no positives, while it's not true in main luabridge (which is stated as "stable"). |
@kunitoki Ok I will update this PR. By the way why not change his name to stable version? e.g. 3.0.4 :) |
What's missing? |
No, that's enough. |
Describe the pull request
What does your PR fix?
Added support for LuaBridge3 header only library https://github.com/kunitoki/LuaBridge3
Which triplets are supported/not supported? Have you updated the CI baseline?
All, No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?I am still working on this PR
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/