Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LuaBridge3] Add new port #26600

Merged
merged 13 commits into from
Sep 29, 2022
Merged

Conversation

kunitoki
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

Added support for LuaBridge3 header only library https://github.com/kunitoki/LuaBridge3

  • Which triplets are supported/not supported? Have you updated the CI baseline?

All, No

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

I am still working on this PR

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 31, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

Use the version scheme "version" instead of "version-string" in port "luabridge3".

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout f688b2e29676bfa3a02ead4b7096c589f8af8180 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 8132c08..31d37be 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4436,6 +4436,10 @@
       "baseline": "2.6",
       "port-version": 1
     },
+    "luabridge3": {
+      "baseline": "3.0",
+      "port-version": 1
+    },
     "luafilesystem": {
       "baseline": "1.8.0",
       "port-version": 2

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/luabridge3/vcpkg.json

Valid values for the license field can be found in the documentation

ports/luabridge3/vcpkg.json Outdated Show resolved Hide resolved
@FrankXie05 FrankXie05 changed the title LuaBridge3 support [LuaBridge3] Add new port Aug 31, 2022
@kunitoki kunitoki marked this pull request as ready for review September 1, 2022 19:40
github-actions[bot]
github-actions bot previously approved these changes Sep 2, 2022
@FrankXie05
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

ports/luabridge3/portfile.cmake Show resolved Hide resolved
ports/luabridge3/portfile.cmake Outdated Show resolved Hide resolved
ports/luabridge3/portfile.cmake Outdated Show resolved Hide resolved
Co-authored-by: Frank <65999885+FrankXie05@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for luabridge3 have changed but the version was not updated
version: 3.0
old SHA: ba41037e81a7c49c91b4e4b3790b05f4b90d8fe1
new SHA: dd80281c8374393b107f109a12cec975477ec088
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@FrankXie05
Copy link
Contributor

Pinging @kunitoki for response. Is work still being done for this PR?

@kunitoki
Copy link
Contributor Author

Yes sorry, was not sure what i had to do. Will look into it tomorrow

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for luabridge3 have changed but the version was not updated
version: 3.0
old SHA: ba41037e81a7c49c91b4e4b3790b05f4b90d8fe1
new SHA: 16439874b9efc941d7611d37c3b33f43bb39f7f9
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@FrankXie05
Copy link
Contributor

@kunitoki Would you mind if I fix this PR for you? :)

@kunitoki
Copy link
Contributor Author

Sure go on

github-actions[bot]
github-actions bot previously approved these changes Sep 26, 2022
@FrankXie05
Copy link
Contributor

@kunitoki Any other suggestions for this PR? :)

FrankXie05
FrankXie05 previously approved these changes Sep 26, 2022
@kunitoki
Copy link
Contributor Author

I've made a new release, shall i update the hash and version ?

btw can the version be changed to 3.0-beta4 ?

@kunitoki
Copy link
Contributor Author

I obviously broke it 😭

@FrankXie05
Copy link
Contributor

@kunitoki According to our policy, we prefer stable releases to beta versions. Unless the beta version specifically states that it is stable. :)

@kunitoki
Copy link
Contributor Author

It's more of a rc than a beta, but it is more stable and secure than the vanilla LuaBridge. It's also being tested with ASAN and UBSAN and produces no positives, while it's not true in main luabridge (which is stated as "stable").

@FrankXie05
Copy link
Contributor

FrankXie05 commented Sep 27, 2022

@kunitoki Ok I will update this PR. By the way why not change his name to stable version? e.g. 3.0.4 :)

github-actions[bot]
github-actions bot previously approved these changes Sep 27, 2022
@kunitoki
Copy link
Contributor Author

What's missing?

@FrankXie05
Copy link
Contributor

No, that's enough.

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Sep 29, 2022
@vicroms vicroms merged commit ab5472a into microsoft:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants