Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glib]: bump version to 2.74.0 #26949

Merged
merged 5 commits into from
Oct 13, 2022
Merged

Conversation

theartful
Copy link
Contributor

@theartful theartful commented Sep 23, 2022

Describe the pull request

Update glib to 2.74.0. Glib now uses git submodules for gvdb, and vcpkg_from_gitlab does not fetch submodules, so I resorted to vcpkg_download_distfile.
I don't know of any other library that uses gvdb, so I think it's okay not to create an entire recipe for it.

github-actions[bot]
github-actions bot previously approved these changes Sep 23, 2022
github-actions[bot]
github-actions bot previously approved these changes Sep 23, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for glib have changed but the version was not updated
version: 2.73.3
old SHA: 5d231c696ced5961e6f0d11a9f4f48e3f2c11916
new SHA: d88604e029c7a57a0c973a26c5b3e805b9f78459
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@theartful theartful changed the title [glib]: bump version to 2.73.3 [glib]: bump version to 2.74.0 Sep 24, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for glib have changed but the version was not updated
version: 2.74.0
old SHA: d88604e029c7a57a0c973a26c5b3e805b9f78459
new SHA: 52b87ac2b4be057c665b94927a552e131e5a920c
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Sep 24, 2022
github-actions[bot]
github-actions bot previously approved these changes Sep 24, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 26, 2022
@JonLiu1993
Copy link
Member

JonLiu1993 commented Sep 27, 2022

@hesham-essam ,Thanks for your pr, when I tested the feature by command "./vcpkg install glib[*]:x64-linux",
I got this error, could you please take a look?

CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:96 (message):
    Command failed: /usr/bin/autoreconf -vfi
    Working Directory: /home/vzhli17/test/vcpkg/buildtrees/libmount/src/2.38-22af6c1200.clean/
    Error code: 2
    See logs for more information:
      /home/test/test/vcpkg/buildtrees/libmount/autoconf-x64-linux-out.log
      /home/test/test/vcpkg/buildtrees/libmount/autoconf-x64-linux-err.log

Call Stack (most recent call first):

/home/test/test/vcpkg/buildtrees/libmount/autoconf-x64-linux-err.log

autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: running: autopoint --force
autoreconf: running: aclocal --force -I m4
autoreconf: configure.ac: tracing
autoreconf: running: libtoolize --copy --force
autoreconf: configure.ac: not using Intltool
autoreconf: running: gtkdocize --copy
Can't exec "gtkdocize": No such file or directory at /usr/share/autoconf/Autom4te/FileUtils.pm line 293.
autoreconf: error: gtkdocize failed with exit status: 2

@dg0yt
Copy link
Contributor

dg0yt commented Sep 27, 2022

autoreconf: running: gtkdocize --copy
Can't exec "gtkdocize": No such file or directory at /usr/share/autoconf/Autom4te/FileUtils.pm line 293.

Since vcpkg doesn't care for docs, it doesn't need gtkdocize. You may turn this step into a no-op by adding this to the portfile:

set(ENV{GTKDOCIZE} true)

Cf. libidn2, libtasn1.

@JonLiu1993
Copy link
Member

I add set(ENV{GTKDOCIZE} true) to libmount portfile.cmake and fix the error, but got the another one:
Tested by command "./vcpkg install glib[*]:x64-linux",


Code:

        #ifdef __has_include
         #if !__has_include("afunix.h")
          #error "Header 'afunix.h' could not be found"
         #endif
        #else
         #include <afunix.h>
        #endif
Compiler stdout:

Compiler stderr:
 /home/test/test/vcpkg/buildtrees/glib/x64-linux-dbg/meson-private/tmp3bnbvpuy/testfile.c:4:12: error: #error "Header 'afunix.h' could not be found"
    4 |           #error "Header 'afunix.h' could not be found"
      |            ^~~~~

Has header "afunix.h" : NO

@dg0yt
Copy link
Contributor

dg0yt commented Sep 28, 2022

Has header "afunix.h" : NO

On my linux machine, afunix.h comes with Ubuntu package linux-headers. (FTR this package is also needed by port openssl, and that port carries a reminder message.)

@theartful
Copy link
Contributor Author

theartful commented Sep 28, 2022

@JonLiu1993
Glib does not have a hard dependency on afunix.h. I get the same message as well, but glib builds without problems all the same (and vcpkg doesn't complain either):

Code:
 
        #ifdef __has_include
         #if !__has_include("afunix.h")
          #error "Header 'afunix.h' could not be found"
         #endif
        #else
         #include <afunix.h>
        #endif
Compiler stdout:
 
Compiler stderr:
 /home/theartful/Programming/vcpkg/buildtrees/glib/x64-linux-dbg/meson-private/tmpfr_q1e90/testfile.c:4:12: error: #error "Header 'afunix.h' could not be found"
    4 |           #error "Header 'afunix.h' could not be found"
      |            ^~~~~

Has header "afunix.h" : NO 

@theartful
Copy link
Contributor Author

Are you sure this is the cause of the build failure?

@JonLiu1993 JonLiu1993 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Oct 11, 2022
@JonLiu1993
Copy link
Member

Are you sure this is the cause of the build failure?

@hesham-essam , I use command "./vcpkg install glib[*]:x64-linux" tested again,
this is error log, please take a look:

autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: running: autopoint --force
autoreconf: running: aclocal --force -I m4
autoreconf: configure.ac: tracing
autoreconf: running: libtoolize --copy --force
autoreconf: configure.ac: not using Intltool
autoreconf: running: gtkdocize --copy
Can't exec "gtkdocize": No such file or directory at /usr/share/autoconf/Autom4te/FileUtils.pm line 293.
autoreconf: error: gtkdocize failed with exit status: 2

github-actions[bot]
github-actions bot previously approved these changes Oct 11, 2022
@theartful
Copy link
Contributor Author

@JonLiu1993 I removed my gtkdocize, reproduced the issue, then applied @dg0yt suggested solution, and things should work now. Please try again.

versions/l-/libmount.json Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot previously approved these changes Oct 12, 2022
@JonLiu1993
Copy link
Member

@hesham-essam , I use command "./vcpkg install glib[*]:x64-linux" tested again,
this is error log, please take a look:

CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:96 (message):
    Command failed: /usr/bin/python3 /home/vzhli17/Jon/vcpkg/installed/x64-linux/tools/meson/meson.py -Dinstalled_tests=false -Dselinux=enabled -Dlibmount=enabled -Dtests=false -Dxattr=false -Dlibelf=disabled --buildtype plain --backend ninja --wrap-mode nodownload --native /home/vzhli17/Jon/vcpkg/buildtrees/glib/meson-native-x64-linux.log --default-library static --libdir lib --native /home/vzhli17/Jon/vcpkg/buildtrees/glib/meson-native-x64-linux-debug.log -Ddebug=true --prefix /home/vzhli17/Jon/vcpkg/packages/glib_x64-linux/debug --includedir ../include -Dcmake_prefix_path=['/home/vzhli17/Jon/vcpkg/installed/x64-linux/debug','/home/vzhli17/Jon/vcpkg/installed/x64-linux'] /home/vzhli17/Jon/vcpkg/buildtrees/glib/src/glib-2-22354247da
    Working Directory: /home/vzhli17/Jon/vcpkg/buildtrees/glib/x64-linux-dbg
    Error code: 1
    See logs for more information:
      /home/test/Jon/vcpkg/buildtrees/glib/config-x64-linux-dbg-meson-log.txt.log
      /home/test/Jon/vcpkg/buildtrees/glib/config-x64-linux-dbg-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_meson.cmake:454 (vcpkg_execute_required_process)
  ports/glib/portfile.cmake:37 (vcpkg_configure_meson)
  scripts/ports.cmake:147 (include)

/home/test/Jon/vcpkg/buildtrees/glib/config-x64-linux-dbg-meson-log.txt.log

Compiler stderr:
 /home/vzhli17/Jon/vcpkg/buildtrees/glib/x64-linux-dbg/meson-private/tmps2at_fp6/testfile.c: In function 'main':
/home/vzhli17/Jon/vcpkg/buildtrees/glib/x64-linux-dbg/meson-private/tmps2at_fp6/testfile.c:17:18: error: #error "__builtin_getvfsstat not found"
   17 |                 #error "__builtin_getvfsstat not found"
      |                  ^~~~~

Checking for function "getvfsstat" : NO
Running compile:

There are many such meson error logs in the log.

@theartful
Copy link
Contributor Author

theartful commented Oct 12, 2022

@JonLiu1993 These are not really errors. Meson performs tests to check if certain functions exist. I get the same stuff

Compiler stderr:
 /home/theartful/Programming/vcpkg/buildtrees/glib/x64-linux-dbg/meson-private/tmp68g4jd6k/testfile.c: In function 'main':
/home/theartful/Programming/vcpkg/buildtrees/glib/x64-linux-dbg/meson-private/tmp68g4jd6k/testfile.c:17:18: error: #error "__builtin_getvfsstat not found"
   17 |                 #error "__builtin_getvfsstat not found"
      |                  ^~~~~

Checking for function "getvfsstat" : NO 

The cause of the error is something else. Can you please send me the log files?

@JonLiu1993
Copy link
Member

@JonLiu1993 These are not really errors. Meson performs tests to check if certain functions exist. I get the same stuff

Compiler stderr:
 /home/theartful/Programming/vcpkg/buildtrees/glib/x64-linux-dbg/meson-private/tmp68g4jd6k/testfile.c: In function 'main':
/home/theartful/Programming/vcpkg/buildtrees/glib/x64-linux-dbg/meson-private/tmp68g4jd6k/testfile.c:17:18: error: #error "__builtin_getvfsstat not found"
   17 |                 #error "__builtin_getvfsstat not found"
      |                  ^~~~~

Checking for function "getvfsstat" : NO 

The cause of the error is something else. Can you please send me the log files?

The error log file Error log I looked into and found a useful piece of information:

../src/glib-2-22354247da/meson.build:2123:2: ERROR: Dependency "libselinux" not found, tried pkgconfig and cmake

@theartful
Copy link
Contributor Author

@JonLiu1993 Well, to enable selinux support, you have to have libselinux installed. If you're on ubuntu, try sudo apt install libselinux1-dev

@JonLiu1993
Copy link
Member

All features are tested successfully in the x64-linux triplet

@JonLiu1993 JonLiu1993 removed requires:author-response requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Oct 12, 2022
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Oct 13, 2022
@vicroms vicroms merged commit 51b5543 into microsoft:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants