-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[glib]: bump version to 2.74.0 #26949
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for glib have changed but the version was not updated
version: 2.73.3
old SHA: 5d231c696ced5961e6f0d11a9f4f48e3f2c11916
new SHA: d88604e029c7a57a0c973a26c5b3e805b9f78459
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for glib have changed but the version was not updated
version: 2.74.0
old SHA: d88604e029c7a57a0c973a26c5b3e805b9f78459
new SHA: 52b87ac2b4be057c665b94927a552e131e5a920c
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
5eda872
to
aec812b
Compare
@hesham-essam ,Thanks for your pr, when I tested the feature by command "./vcpkg install glib[*]:x64-linux",
/home/test/test/vcpkg/buildtrees/libmount/autoconf-x64-linux-err.log
|
Since vcpkg doesn't care for docs, it doesn't need
Cf. libidn2, libtasn1. |
I add
|
On my linux machine, |
@JonLiu1993
|
Are you sure this is the cause of the build failure? |
@hesham-essam , I use command "./vcpkg install glib[*]:x64-linux" tested again,
|
@JonLiu1993 I removed my gtkdocize, reproduced the issue, then applied @dg0yt suggested solution, and things should work now. Please try again. |
@hesham-essam , I use command "./vcpkg install glib[*]:x64-linux" tested again,
/home/test/Jon/vcpkg/buildtrees/glib/config-x64-linux-dbg-meson-log.txt.log
There are many such meson error logs in the log. |
@JonLiu1993 These are not really errors. Meson performs tests to check if certain functions exist. I get the same stuff
The cause of the error is something else. Can you please send me the log files? |
The error log file Error log I looked into and found a useful piece of information:
|
@JonLiu1993 Well, to enable selinux support, you have to have libselinux installed. If you're on ubuntu, try |
All features are tested successfully in the x64-linux triplet |
Describe the pull request
Update glib to 2.74.0. Glib now uses git submodules for gvdb, and
vcpkg_from_gitlab
does not fetch submodules, so I resorted tovcpkg_download_distfile
.I don't know of any other library that uses gvdb, so I think it's okay not to create an entire recipe for it.