-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scripts|nmake] Add jom
option, add language control
#27255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/librttopo/vcpkg.json
ports/spatialite-tools/vcpkg.json
Valid values for the license field can be found in the documentation
[PROJECT_SUBPATH <${SUBPATH}>] | ||
[PROJECT_NAME <${MAKEFILE_NAME}>] | ||
[LOGFILE_ROOT <prefix>] | ||
[CL_LANGUAGE <language-name>] | ||
[PREFER_JOM] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably no. Have jom be the default and deactivate it with a VCPKG_NMAKE_NO_JOM
?. similar how qmake has VCPKG_QMAKE_USE_NMAKE
. The reason not to even try using jom is that Jom has consistencies issues on some machines and keeps dead locking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"No" what?
jom
is proposed as opt-in just because it has the potential to break working builds.
(For openssl, the most important mitigation is to configure with no-makedepend
.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Qt came with its own tool for generating (n)makefiles. In the Qt world, jom compatibility is a reasonable assumption. But outside Qt, we can't rely on makefiles being designed and tested for concurrency.
@vicroms et al. Please don't let this wait too long in requires:vcpkg-team-review. I would like to continue the openssl cleanup (#27150, #27261).
|
@vicroms Ping again. |
Tagging reviewed so that I look at this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct to me, in particular the dispute over PREFER_JOM
here preserving backwards compatibility seems to be resolved correctly to me.
I'm going to poke @vicroms in person one more time and merge this if I get no reply tomorrow.
Thanks for the help @dg0yt ! |
Now I can look into openssl again. |
Pulled out of #27150:
What does your PR fix?
Two independent contributions:
_CL_
setup for C projects, fixing (re-enabling) uwp builds for nmake C projects.jom
(inspired by and targeting port openssl, but also beneficial for libspatialite etc.)Which triplets are supported/not supported? Have you updated the CI baseline?
windows, yes
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes