Add X windows part 12/N #27512
Merged
Add X windows part 12/N #27512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libdmx/vcpkg.jsonports/xbitmaps/vcpkg.json
Valid values for the license field can be found in the documentation
LilyWangLL
added
the
category:new-port
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libdmx/vcpkg.jsonports/xbitmaps/vcpkg.json
Valid values for the license field can be found in the documentation
LilyWangLL
previously approved these changes
Oct 31, 2022
Cheney-W
previously approved these changes
Oct 31, 2022
BillyONeal
dismissed stale reviews from Cheney-W, LilyWangLL, and github-actions[bot]
via
07e2dc0
BillyONeal
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
New port checklist:
- Review the code ✅✅✅
⚠️ - Check the name against https://repology.org/ ✅✅✅
- Check the name against Bing/Google. ✅ Skipped.
- Check the source code for optional
find_packages ✅ None are CMake. - Check that the versioning scheme matches what upstream says ✅✅✅
- Check that the license in vcpkg.json matches what upstream says ✅✅✅
- Check that the license installed by the port matches what upstream says ✅✅✅
- Check that the source code comes from the upstream project's authoritative source. ✅✅✅
- Check that the generated usage is accurate. ✅✅✅ No usage.
- Check for issues that are resolved. ✅✅✅
I pushed a SHA fix and a copyright install style fix.
Cheney-W
added
requires:author-response
and removed
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.