Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[seacas/vtkm/vtk/paraview] Add/update ports. #27928

Merged
merged 137 commits into from
Jan 20, 2023

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Nov 20, 2022

  • add trilinos seacas port (since only that is used by vtk)
  • add verdict port
  • update vtkm
  • update vtk
  • update paraview to 5.11
  • fix issues observed along the way

see if linux/osx CI works. Only tested windows with paraview[core,mpi,python,tools,vtkm]

TODO: add https://gitlab.kitware.com/vtk/vtk/-/commit/bfa3e4c7621ddf5826755536eb07284c86db6474.diff
Fixes #23926.

Neumann-A and others added 21 commits June 2, 2021 21:29
- VTK update to match release version of ParaView
- fix build with vtk-m 1.6
- remove unused patches
- remove comments
# Conflicts:
#	ports/cgns/hdf5.patch
#	ports/cgns/portfile.cmake
#	ports/cgns/vcpkg.json
#	ports/paraview/portfile.cmake
#	ports/paraview/vcpkg.json
#	ports/qt5-svg/CONTROL
#	ports/vtk-m/portfile.cmake
#	ports/vtk-m/vcpkg.json
#	ports/vtk/portfile.cmake
#	ports/vtk/vcpkg.json
#	versions/baseline.json
#	versions/c-/cgns.json
#	versions/p-/paraview.json
#	versions/q-/qt5-svg.json
#	versions/v-/vtk-m.json
#	versions/v-/vtk.json
# Conflicts:
#	ports/libharu/portfile.cmake
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/trilinos/vcpkg.json b/ports/trilinos/vcpkg.json
index 2f9d520e..8a88aa80 100644
--- a/ports/trilinos/vcpkg.json
+++ b/ports/trilinos/vcpkg.json
@@ -4,31 +4,31 @@
   "description": "The Trilinos Project is an effort to develop algorithms and enabling technologies within an object-oriented software framework for the solution of large-scale, complex multi-physics engineering and scientific problems. A unique design feature of Trilinos is its focus on packages.",
   "homepage": "https://github.com/trilinos/Trilinos",
   "license": null,
-  "dependencies" : [
+  "dependencies": [
+    "cereal",
     "cgns",
-    "matio",
-    "netcdf-c",
-    "hwloc",
-    "hdf5",
-    "zlib",
     "fmt",
+    "hdf5",
+    "hwloc",
+    "matio",
     "metis",
-    "cereal",
-            {
+    "netcdf-c",
+    {
       "name": "pkgconf",
       "host": true
     },
-        {
+    {
       "name": "python3",
       "host": true
     },
-        {
+    {
       "name": "vcpkg-cmake",
       "host": true
     },
     {
       "name": "vcpkg-cmake-config",
       "host": true
-    }
-   ]
+    },
+    "zlib"
+  ]
 }
diff --git a/ports/verdict/vcpkg.json b/ports/verdict/vcpkg.json
index b62d06f0..220817da 100644
--- a/ports/verdict/vcpkg.json
+++ b/ports/verdict/vcpkg.json
@@ -4,8 +4,8 @@
   "description": "Compute quality functions of 2 and 3-dimensional regions.",
   "homepage": "https://github.com/sandialabs/verdict",
   "license": null,
-  "dependencies" : [
-        {
+  "dependencies": [
+    {
       "name": "vcpkg-cmake",
       "host": true
     },
@@ -13,5 +13,5 @@
       "name": "vcpkg-cmake-config",
       "host": true
     }
-   ]
+  ]
 }
diff --git a/ports/vtk/vcpkg.json b/ports/vtk/vcpkg.json
index 7fe76a31..eaa0de01 100644
--- a/ports/vtk/vcpkg.json
+++ b/ports/vtk/vcpkg.json
@@ -8,6 +8,8 @@
     "double-conversion",
     "eigen3",
     "expat",
+    "exprtk",
+    "fmt",
     "freetype",
     "glew",
     {
@@ -32,11 +34,8 @@
     "pugixml",
     "sqlite3",
     "tiff",
-    "utfcpp",
-    "exprtk",
-    "fmt",
     "trilinos",
-    "verdict",
+    "utfcpp",
     {
       "name": "vcpkg-cmake",
       "host": true
@@ -45,6 +44,7 @@
       "name": "vcpkg-cmake-config",
       "host": true
     },
+    "verdict",
     "zlib"
   ],
   "features": {
@@ -145,6 +145,7 @@
     "paraview": {
       "description": "Build vtk modules required by paraview",
       "dependencies": [
+        "cli11",
         {
           "name": "vtk",
           "default-features": false,
@@ -152,7 +153,6 @@
             "qt"
           ]
         },
-        "cli11",
         {
           "name": "vtk",
           "default-features": false,
@@ -172,9 +172,9 @@
     "qt": {
       "description": "Qt functionality for VTK",
       "dependencies": [
+        "qt5-declarative",
         "qt5-imageformats",
         "qt5-tools",
-        "qt5-declarative",
         {
           "name": "qt5-x11extras",
           "platform": "linux"
PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for netcdf-c have changed but the version was not updated
version: 4.8.1#2
old SHA: f4d487e2f7e093b2406887023bb3a0856735bad5
new SHA: 41430ae67e8596bf7fabfc70507890c98358fd9e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for cgns have changed but the version was not updated
version: 4.3.0#1
old SHA: 1733a3011caebf67ccbe1d48ea08c92e87d186e0
new SHA: cd09f67eea6c4dfd1430f04aedd3eb1ab12bd557
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for hdf5 have changed but the version was not updated
version: 1.12.2#3
old SHA: 49bd00fad1be159f72151186015b20bf095f4177
new SHA: feb62baff779472d9d5b3284b4c0052b1b9d05a5
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 4cb4a5c5ddcb9de0c83c85837ee6974c8333f032 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 8c455bfb..e0159dc5 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2880,6 +2880,10 @@
       "baseline": "1.12.2",
       "port-version": 3
     },
+    "hdf5-exp": {
+      "baseline": "1.13.3",
+      "port-version": 0
+    },
     "healpix": {
       "baseline": "1.12.10",
       "port-version": 8
@@ -5677,8 +5681,8 @@
       "port-version": 1
     },
     "paraview": {
-      "baseline": "5.9.1",
-      "port-version": 2
+      "baseline": "5.11.0",
+      "port-version": 0
     },
     "parmetis": {
       "baseline": "2022-07-27",
@@ -7584,6 +7588,10 @@
       "baseline": "1.6",
       "port-version": 2
     },
+    "trilinos": {
+      "baseline": "13.4.1+20221112",
+      "port-version": 0
+    },
     "triton": {
       "baseline": "0.9",
       "port-version": 5
@@ -7840,6 +7848,10 @@
       "baseline": "2.02.00",
       "port-version": 0
     },
+    "verdict": {
+      "baseline": "1.4.0",
+      "port-version": 0
+    },
     "visit-struct": {
       "baseline": "1.0",
       "port-version": 2
@@ -7873,16 +7885,16 @@
       "port-version": 1
     },
     "vtk": {
-      "baseline": "9.0.3-pv5.9.1",
-      "port-version": 12
+      "baseline": "9.2.0-pv5.11.0",
+      "port-version": 0
     },
     "vtk-dicom": {
       "baseline": "0.8.12",
       "port-version": 2
     },
     "vtk-m": {
-      "baseline": "1.6.0",
-      "port-version": 2
+      "baseline": "1.9.0",
+      "port-version": 0
     },
     "vulkan": {
       "baseline": "1.1.82.1",
diff --git a/versions/p-/paraview.json b/versions/p-/paraview.json
index 91d43f8c..0a69e1d9 100644
--- a/versions/p-/paraview.json
+++ b/versions/p-/paraview.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "a9528d9364233026f84f93ac54be5594cf2fb460",
+      "version": "5.11.0",
+      "port-version": 0
+    },
     {
       "git-tree": "8f5d22c6754f293f54a360472f78e760f06aae80",
       "version": "5.9.1",
diff --git a/versions/v-/vtk-m.json b/versions/v-/vtk-m.json
index d96689fa..9b39d767 100644
--- a/versions/v-/vtk-m.json
+++ b/versions/v-/vtk-m.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "50168acdf8fd4847749564a76e27292c73d4faca",
+      "version-semver": "1.9.0",
+      "port-version": 0
+    },
     {
       "git-tree": "bfd540dbdb5d0684ea4e5363e3b32cfceadcb542",
       "version-semver": "1.6.0",
diff --git a/versions/v-/vtk.json b/versions/v-/vtk.json
index 5423109b..c9727585 100644
--- a/versions/v-/vtk.json
+++ b/versions/v-/vtk.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "36e5538dd2ed8aff4aee69dfc5896aa638b1efd8",
+      "version-semver": "9.2.0-pv5.11.0",
+      "port-version": 0
+    },
     {
       "git-tree": "64cd3c51764272ed1c8acc2d5fa37106d9f76b66",
       "version-semver": "9.0.3-pv5.9.1",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/paraview/portfile.cmake
  • ports/vtk/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/vtk-m/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/trilinos/vcpkg.json b/ports/trilinos/vcpkg.json
index 2f9d520e..8a88aa80 100644
--- a/ports/trilinos/vcpkg.json
+++ b/ports/trilinos/vcpkg.json
@@ -4,31 +4,31 @@
   "description": "The Trilinos Project is an effort to develop algorithms and enabling technologies within an object-oriented software framework for the solution of large-scale, complex multi-physics engineering and scientific problems. A unique design feature of Trilinos is its focus on packages.",
   "homepage": "https://github.com/trilinos/Trilinos",
   "license": null,
-  "dependencies" : [
+  "dependencies": [
+    "cereal",
     "cgns",
-    "matio",
-    "netcdf-c",
-    "hwloc",
-    "hdf5",
-    "zlib",
     "fmt",
+    "hdf5",
+    "hwloc",
+    "matio",
     "metis",
-    "cereal",
-            {
+    "netcdf-c",
+    {
       "name": "pkgconf",
       "host": true
     },
-        {
+    {
       "name": "python3",
       "host": true
     },
-        {
+    {
       "name": "vcpkg-cmake",
       "host": true
     },
     {
       "name": "vcpkg-cmake-config",
       "host": true
-    }
-   ]
+    },
+    "zlib"
+  ]
 }
diff --git a/ports/verdict/vcpkg.json b/ports/verdict/vcpkg.json
index b62d06f0..220817da 100644
--- a/ports/verdict/vcpkg.json
+++ b/ports/verdict/vcpkg.json
@@ -4,8 +4,8 @@
   "description": "Compute quality functions of 2 and 3-dimensional regions.",
   "homepage": "https://github.com/sandialabs/verdict",
   "license": null,
-  "dependencies" : [
-        {
+  "dependencies": [
+    {
       "name": "vcpkg-cmake",
       "host": true
     },
@@ -13,5 +13,5 @@
       "name": "vcpkg-cmake-config",
       "host": true
     }
-   ]
+  ]
 }
diff --git a/ports/vtk/vcpkg.json b/ports/vtk/vcpkg.json
index 7fe76a31..eaa0de01 100644
--- a/ports/vtk/vcpkg.json
+++ b/ports/vtk/vcpkg.json
@@ -8,6 +8,8 @@
     "double-conversion",
     "eigen3",
     "expat",
+    "exprtk",
+    "fmt",
     "freetype",
     "glew",
     {
@@ -32,11 +34,8 @@
     "pugixml",
     "sqlite3",
     "tiff",
-    "utfcpp",
-    "exprtk",
-    "fmt",
     "trilinos",
-    "verdict",
+    "utfcpp",
     {
       "name": "vcpkg-cmake",
       "host": true
@@ -45,6 +44,7 @@
       "name": "vcpkg-cmake-config",
       "host": true
     },
+    "verdict",
     "zlib"
   ],
   "features": {
@@ -145,6 +145,7 @@
     "paraview": {
       "description": "Build vtk modules required by paraview",
       "dependencies": [
+        "cli11",
         {
           "name": "vtk",
           "default-features": false,
@@ -152,7 +153,6 @@
             "qt"
           ]
         },
-        "cli11",
         {
           "name": "vtk",
           "default-features": false,
@@ -172,9 +172,9 @@
     "qt": {
       "description": "Qt functionality for VTK",
       "dependencies": [
+        "qt5-declarative",
         "qt5-imageformats",
         "qt5-tools",
-        "qt5-declarative",
         {
           "name": "qt5-x11extras",
           "platform": "linux"
PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for netcdf-c have changed but the version was not updated
version: 4.8.1#2
old SHA: f4d487e2f7e093b2406887023bb3a0856735bad5
new SHA: 41430ae67e8596bf7fabfc70507890c98358fd9e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for cgns have changed but the version was not updated
version: 4.3.0#1
old SHA: 1733a3011caebf67ccbe1d48ea08c92e87d186e0
new SHA: cd09f67eea6c4dfd1430f04aedd3eb1ab12bd557
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for hdf5 have changed but the version was not updated
version: 1.12.2#3
old SHA: 49bd00fad1be159f72151186015b20bf095f4177
new SHA: feb62baff779472d9d5b3284b4c0052b1b9d05a5
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 4cb4a5c5ddcb9de0c83c85837ee6974c8333f032 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 8c455bfb..e0159dc5 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2880,6 +2880,10 @@
       "baseline": "1.12.2",
       "port-version": 3
     },
+    "hdf5-exp": {
+      "baseline": "1.13.3",
+      "port-version": 0
+    },
     "healpix": {
       "baseline": "1.12.10",
       "port-version": 8
@@ -5677,8 +5681,8 @@
       "port-version": 1
     },
     "paraview": {
-      "baseline": "5.9.1",
-      "port-version": 2
+      "baseline": "5.11.0",
+      "port-version": 0
     },
     "parmetis": {
       "baseline": "2022-07-27",
@@ -7584,6 +7588,10 @@
       "baseline": "1.6",
       "port-version": 2
     },
+    "trilinos": {
+      "baseline": "13.4.1+20221112",
+      "port-version": 0
+    },
     "triton": {
       "baseline": "0.9",
       "port-version": 5
@@ -7840,6 +7848,10 @@
       "baseline": "2.02.00",
       "port-version": 0
     },
+    "verdict": {
+      "baseline": "1.4.0",
+      "port-version": 0
+    },
     "visit-struct": {
       "baseline": "1.0",
       "port-version": 2
@@ -7873,16 +7885,16 @@
       "port-version": 1
     },
     "vtk": {
-      "baseline": "9.0.3-pv5.9.1",
-      "port-version": 12
+      "baseline": "9.2.0-pv5.11.0",
+      "port-version": 0
     },
     "vtk-dicom": {
       "baseline": "0.8.12",
       "port-version": 2
     },
     "vtk-m": {
-      "baseline": "1.6.0",
-      "port-version": 2
+      "baseline": "1.9.0",
+      "port-version": 0
     },
     "vulkan": {
       "baseline": "1.1.82.1",
diff --git a/versions/p-/paraview.json b/versions/p-/paraview.json
index 91d43f8c..0a69e1d9 100644
--- a/versions/p-/paraview.json
+++ b/versions/p-/paraview.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "a9528d9364233026f84f93ac54be5594cf2fb460",
+      "version": "5.11.0",
+      "port-version": 0
+    },
     {
       "git-tree": "8f5d22c6754f293f54a360472f78e760f06aae80",
       "version": "5.9.1",
diff --git a/versions/v-/vtk-m.json b/versions/v-/vtk-m.json
index d96689fa..9b39d767 100644
--- a/versions/v-/vtk-m.json
+++ b/versions/v-/vtk-m.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "50168acdf8fd4847749564a76e27292c73d4faca",
+      "version-semver": "1.9.0",
+      "port-version": 0
+    },
     {
       "git-tree": "bfd540dbdb5d0684ea4e5363e3b32cfceadcb542",
       "version-semver": "1.6.0",
diff --git a/versions/v-/vtk.json b/versions/v-/vtk.json
index 5423109b..c9727585 100644
--- a/versions/v-/vtk.json
+++ b/versions/v-/vtk.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "36e5538dd2ed8aff4aee69dfc5896aa638b1efd8",
+      "version-semver": "9.2.0-pv5.11.0",
+      "port-version": 0
+    },
     {
       "git-tree": "64cd3c51764272ed1c8acc2d5fa37106d9f76b66",
       "version-semver": "9.0.3-pv5.9.1",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/paraview/portfile.cmake
  • ports/vtk/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/vtk-m/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/trilinos/vcpkg.json b/ports/trilinos/vcpkg.json
index 2f9d520e..8a88aa80 100644
--- a/ports/trilinos/vcpkg.json
+++ b/ports/trilinos/vcpkg.json
@@ -4,31 +4,31 @@
   "description": "The Trilinos Project is an effort to develop algorithms and enabling technologies within an object-oriented software framework for the solution of large-scale, complex multi-physics engineering and scientific problems. A unique design feature of Trilinos is its focus on packages.",
   "homepage": "https://github.com/trilinos/Trilinos",
   "license": null,
-  "dependencies" : [
+  "dependencies": [
+    "cereal",
     "cgns",
-    "matio",
-    "netcdf-c",
-    "hwloc",
-    "hdf5",
-    "zlib",
     "fmt",
+    "hdf5",
+    "hwloc",
+    "matio",
     "metis",
-    "cereal",
-            {
+    "netcdf-c",
+    {
       "name": "pkgconf",
       "host": true
     },
-        {
+    {
       "name": "python3",
       "host": true
     },
-        {
+    {
       "name": "vcpkg-cmake",
       "host": true
     },
     {
       "name": "vcpkg-cmake-config",
       "host": true
-    }
-   ]
+    },
+    "zlib"
+  ]
 }
diff --git a/ports/verdict/vcpkg.json b/ports/verdict/vcpkg.json
index b62d06f0..220817da 100644
--- a/ports/verdict/vcpkg.json
+++ b/ports/verdict/vcpkg.json
@@ -4,8 +4,8 @@
   "description": "Compute quality functions of 2 and 3-dimensional regions.",
   "homepage": "https://github.com/sandialabs/verdict",
   "license": null,
-  "dependencies" : [
-        {
+  "dependencies": [
+    {
       "name": "vcpkg-cmake",
       "host": true
     },
@@ -13,5 +13,5 @@
       "name": "vcpkg-cmake-config",
       "host": true
     }
-   ]
+  ]
 }
diff --git a/ports/vtk/vcpkg.json b/ports/vtk/vcpkg.json
index 7fe76a31..eaa0de01 100644
--- a/ports/vtk/vcpkg.json
+++ b/ports/vtk/vcpkg.json
@@ -8,6 +8,8 @@
     "double-conversion",
     "eigen3",
     "expat",
+    "exprtk",
+    "fmt",
     "freetype",
     "glew",
     {
@@ -32,11 +34,8 @@
     "pugixml",
     "sqlite3",
     "tiff",
-    "utfcpp",
-    "exprtk",
-    "fmt",
     "trilinos",
-    "verdict",
+    "utfcpp",
     {
       "name": "vcpkg-cmake",
       "host": true
@@ -45,6 +44,7 @@
       "name": "vcpkg-cmake-config",
       "host": true
     },
+    "verdict",
     "zlib"
   ],
   "features": {
@@ -145,6 +145,7 @@
     "paraview": {
       "description": "Build vtk modules required by paraview",
       "dependencies": [
+        "cli11",
         {
           "name": "vtk",
           "default-features": false,
@@ -152,7 +153,6 @@
             "qt"
           ]
         },
-        "cli11",
         {
           "name": "vtk",
           "default-features": false,
@@ -172,9 +172,9 @@
     "qt": {
       "description": "Qt functionality for VTK",
       "dependencies": [
+        "qt5-declarative",
         "qt5-imageformats",
         "qt5-tools",
-        "qt5-declarative",
         {
           "name": "qt5-x11extras",
           "platform": "linux"
PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for netcdf-c have changed but the version was not updated
version: 4.8.1#2
old SHA: f4d487e2f7e093b2406887023bb3a0856735bad5
new SHA: 41430ae67e8596bf7fabfc70507890c98358fd9e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for cgns have changed but the version was not updated
version: 4.3.0#1
old SHA: 1733a3011caebf67ccbe1d48ea08c92e87d186e0
new SHA: cd09f67eea6c4dfd1430f04aedd3eb1ab12bd557
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for hdf5 have changed but the version was not updated
version: 1.12.2#3
old SHA: 49bd00fad1be159f72151186015b20bf095f4177
new SHA: 4c082b23d594c3761d97f01a7845fd2b26f543e8
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 4cb4a5c5ddcb9de0c83c85837ee6974c8333f032 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 8c455bfb..043377a8 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5677,8 +5677,8 @@
       "port-version": 1
     },
     "paraview": {
-      "baseline": "5.9.1",
-      "port-version": 2
+      "baseline": "5.11.0",
+      "port-version": 0
     },
     "parmetis": {
       "baseline": "2022-07-27",
@@ -7584,6 +7584,10 @@
       "baseline": "1.6",
       "port-version": 2
     },
+    "trilinos": {
+      "baseline": "13.4.1+20221112",
+      "port-version": 0
+    },
     "triton": {
       "baseline": "0.9",
       "port-version": 5
@@ -7840,6 +7844,10 @@
       "baseline": "2.02.00",
       "port-version": 0
     },
+    "verdict": {
+      "baseline": "1.4.0",
+      "port-version": 0
+    },
     "visit-struct": {
       "baseline": "1.0",
       "port-version": 2
@@ -7873,16 +7881,16 @@
       "port-version": 1
     },
     "vtk": {
-      "baseline": "9.0.3-pv5.9.1",
-      "port-version": 12
+      "baseline": "9.2.0-pv5.11.0",
+      "port-version": 0
     },
     "vtk-dicom": {
       "baseline": "0.8.12",
       "port-version": 2
     },
     "vtk-m": {
-      "baseline": "1.6.0",
-      "port-version": 2
+      "baseline": "1.9.0",
+      "port-version": 0
     },
     "vulkan": {
       "baseline": "1.1.82.1",
diff --git a/versions/p-/paraview.json b/versions/p-/paraview.json
index 91d43f8c..0a69e1d9 100644
--- a/versions/p-/paraview.json
+++ b/versions/p-/paraview.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "a9528d9364233026f84f93ac54be5594cf2fb460",
+      "version": "5.11.0",
+      "port-version": 0
+    },
     {
       "git-tree": "8f5d22c6754f293f54a360472f78e760f06aae80",
       "version": "5.9.1",
diff --git a/versions/v-/vtk-m.json b/versions/v-/vtk-m.json
index d96689fa..9b39d767 100644
--- a/versions/v-/vtk-m.json
+++ b/versions/v-/vtk-m.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "50168acdf8fd4847749564a76e27292c73d4faca",
+      "version-semver": "1.9.0",
+      "port-version": 0
+    },
     {
       "git-tree": "bfd540dbdb5d0684ea4e5363e3b32cfceadcb542",
       "version-semver": "1.6.0",
diff --git a/versions/v-/vtk.json b/versions/v-/vtk.json
index 5423109b..c9727585 100644
--- a/versions/v-/vtk.json
+++ b/versions/v-/vtk.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "36e5538dd2ed8aff4aee69dfc5896aa638b1efd8",
+      "version-semver": "9.2.0-pv5.11.0",
+      "port-version": 0
+    },
     {
       "git-tree": "64cd3c51764272ed1c8acc2d5fa37106d9f76b66",
       "version-semver": "9.0.3-pv5.9.1",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/paraview/portfile.cmake
  • ports/vtk/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/vtk-m/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/trilinos/vcpkg.json b/ports/trilinos/vcpkg.json
index 2f9d520e..8a88aa80 100644
--- a/ports/trilinos/vcpkg.json
+++ b/ports/trilinos/vcpkg.json
@@ -4,31 +4,31 @@
   "description": "The Trilinos Project is an effort to develop algorithms and enabling technologies within an object-oriented software framework for the solution of large-scale, complex multi-physics engineering and scientific problems. A unique design feature of Trilinos is its focus on packages.",
   "homepage": "https://github.com/trilinos/Trilinos",
   "license": null,
-  "dependencies" : [
+  "dependencies": [
+    "cereal",
     "cgns",
-    "matio",
-    "netcdf-c",
-    "hwloc",
-    "hdf5",
-    "zlib",
     "fmt",
+    "hdf5",
+    "hwloc",
+    "matio",
     "metis",
-    "cereal",
-            {
+    "netcdf-c",
+    {
       "name": "pkgconf",
       "host": true
     },
-        {
+    {
       "name": "python3",
       "host": true
     },
-        {
+    {
       "name": "vcpkg-cmake",
       "host": true
     },
     {
       "name": "vcpkg-cmake-config",
       "host": true
-    }
-   ]
+    },
+    "zlib"
+  ]
 }
diff --git a/ports/verdict/vcpkg.json b/ports/verdict/vcpkg.json
index b62d06f0..220817da 100644
--- a/ports/verdict/vcpkg.json
+++ b/ports/verdict/vcpkg.json
@@ -4,8 +4,8 @@
   "description": "Compute quality functions of 2 and 3-dimensional regions.",
   "homepage": "https://github.com/sandialabs/verdict",
   "license": null,
-  "dependencies" : [
-        {
+  "dependencies": [
+    {
       "name": "vcpkg-cmake",
       "host": true
     },
@@ -13,5 +13,5 @@
       "name": "vcpkg-cmake-config",
       "host": true
     }
-   ]
+  ]
 }
diff --git a/ports/vtk/vcpkg.json b/ports/vtk/vcpkg.json
index 7fe76a31..eaa0de01 100644
--- a/ports/vtk/vcpkg.json
+++ b/ports/vtk/vcpkg.json
@@ -8,6 +8,8 @@
     "double-conversion",
     "eigen3",
     "expat",
+    "exprtk",
+    "fmt",
     "freetype",
     "glew",
     {
@@ -32,11 +34,8 @@
     "pugixml",
     "sqlite3",
     "tiff",
-    "utfcpp",
-    "exprtk",
-    "fmt",
     "trilinos",
-    "verdict",
+    "utfcpp",
     {
       "name": "vcpkg-cmake",
       "host": true
@@ -45,6 +44,7 @@
       "name": "vcpkg-cmake-config",
       "host": true
     },
+    "verdict",
     "zlib"
   ],
   "features": {
@@ -145,6 +145,7 @@
     "paraview": {
       "description": "Build vtk modules required by paraview",
       "dependencies": [
+        "cli11",
         {
           "name": "vtk",
           "default-features": false,
@@ -152,7 +153,6 @@
             "qt"
           ]
         },
-        "cli11",
         {
           "name": "vtk",
           "default-features": false,
@@ -172,9 +172,9 @@
     "qt": {
       "description": "Qt functionality for VTK",
       "dependencies": [
+        "qt5-declarative",
         "qt5-imageformats",
         "qt5-tools",
-        "qt5-declarative",
         {
           "name": "qt5-x11extras",
           "platform": "linux"
PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for netcdf-c have changed but the version was not updated
version: 4.8.1#2
old SHA: f4d487e2f7e093b2406887023bb3a0856735bad5
new SHA: 41430ae67e8596bf7fabfc70507890c98358fd9e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for cgns have changed but the version was not updated
version: 4.3.0#1
old SHA: 1733a3011caebf67ccbe1d48ea08c92e87d186e0
new SHA: cd09f67eea6c4dfd1430f04aedd3eb1ab12bd557
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for hdf5 have changed but the version was not updated
version: 1.12.2#3
old SHA: 49bd00fad1be159f72151186015b20bf095f4177
new SHA: c1b7be3bcdb47053033d42216a40883843d9c05a
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 4cb4a5c5ddcb9de0c83c85837ee6974c8333f032 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 8c455bfb..043377a8 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5677,8 +5677,8 @@
       "port-version": 1
     },
     "paraview": {
-      "baseline": "5.9.1",
-      "port-version": 2
+      "baseline": "5.11.0",
+      "port-version": 0
     },
     "parmetis": {
       "baseline": "2022-07-27",
@@ -7584,6 +7584,10 @@
       "baseline": "1.6",
       "port-version": 2
     },
+    "trilinos": {
+      "baseline": "13.4.1+20221112",
+      "port-version": 0
+    },
     "triton": {
       "baseline": "0.9",
       "port-version": 5
@@ -7840,6 +7844,10 @@
       "baseline": "2.02.00",
       "port-version": 0
     },
+    "verdict": {
+      "baseline": "1.4.0",
+      "port-version": 0
+    },
     "visit-struct": {
       "baseline": "1.0",
       "port-version": 2
@@ -7873,16 +7881,16 @@
       "port-version": 1
     },
     "vtk": {
-      "baseline": "9.0.3-pv5.9.1",
-      "port-version": 12
+      "baseline": "9.2.0-pv5.11.0",
+      "port-version": 0
     },
     "vtk-dicom": {
       "baseline": "0.8.12",
       "port-version": 2
     },
     "vtk-m": {
-      "baseline": "1.6.0",
-      "port-version": 2
+      "baseline": "1.9.0",
+      "port-version": 0
     },
     "vulkan": {
       "baseline": "1.1.82.1",
diff --git a/versions/p-/paraview.json b/versions/p-/paraview.json
index 91d43f8c..0a69e1d9 100644
--- a/versions/p-/paraview.json
+++ b/versions/p-/paraview.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "a9528d9364233026f84f93ac54be5594cf2fb460",
+      "version": "5.11.0",
+      "port-version": 0
+    },
     {
       "git-tree": "8f5d22c6754f293f54a360472f78e760f06aae80",
       "version": "5.9.1",
diff --git a/versions/v-/vtk-m.json b/versions/v-/vtk-m.json
index d96689fa..9b39d767 100644
--- a/versions/v-/vtk-m.json
+++ b/versions/v-/vtk-m.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "50168acdf8fd4847749564a76e27292c73d4faca",
+      "version-semver": "1.9.0",
+      "port-version": 0
+    },
     {
       "git-tree": "bfd540dbdb5d0684ea4e5363e3b32cfceadcb542",
       "version-semver": "1.6.0",
diff --git a/versions/v-/vtk.json b/versions/v-/vtk.json
index 5423109b..c9727585 100644
--- a/versions/v-/vtk.json
+++ b/versions/v-/vtk.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "36e5538dd2ed8aff4aee69dfc5896aa638b1efd8",
+      "version-semver": "9.2.0-pv5.11.0",
+      "port-version": 0
+    },
     {
       "git-tree": "64cd3c51764272ed1c8acc2d5fa37106d9f76b66",
       "version-semver": "9.0.3-pv5.9.1",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/paraview/portfile.cmake
  • ports/vtk/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/vtk-m/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/trilinos/vcpkg.json b/ports/trilinos/vcpkg.json
index 2f9d520e..8a88aa80 100644
--- a/ports/trilinos/vcpkg.json
+++ b/ports/trilinos/vcpkg.json
@@ -4,31 +4,31 @@
   "description": "The Trilinos Project is an effort to develop algorithms and enabling technologies within an object-oriented software framework for the solution of large-scale, complex multi-physics engineering and scientific problems. A unique design feature of Trilinos is its focus on packages.",
   "homepage": "https://github.com/trilinos/Trilinos",
   "license": null,
-  "dependencies" : [
+  "dependencies": [
+    "cereal",
     "cgns",
-    "matio",
-    "netcdf-c",
-    "hwloc",
-    "hdf5",
-    "zlib",
     "fmt",
+    "hdf5",
+    "hwloc",
+    "matio",
     "metis",
-    "cereal",
-            {
+    "netcdf-c",
+    {
       "name": "pkgconf",
       "host": true
     },
-        {
+    {
       "name": "python3",
       "host": true
     },
-        {
+    {
       "name": "vcpkg-cmake",
       "host": true
     },
     {
       "name": "vcpkg-cmake-config",
       "host": true
-    }
-   ]
+    },
+    "zlib"
+  ]
 }
diff --git a/ports/verdict/vcpkg.json b/ports/verdict/vcpkg.json
index b62d06f0..220817da 100644
--- a/ports/verdict/vcpkg.json
+++ b/ports/verdict/vcpkg.json
@@ -4,8 +4,8 @@
   "description": "Compute quality functions of 2 and 3-dimensional regions.",
   "homepage": "https://github.com/sandialabs/verdict",
   "license": null,
-  "dependencies" : [
-        {
+  "dependencies": [
+    {
       "name": "vcpkg-cmake",
       "host": true
     },
@@ -13,5 +13,5 @@
       "name": "vcpkg-cmake-config",
       "host": true
     }
-   ]
+  ]
 }
diff --git a/ports/vtk/vcpkg.json b/ports/vtk/vcpkg.json
index 7fe76a31..eaa0de01 100644
--- a/ports/vtk/vcpkg.json
+++ b/ports/vtk/vcpkg.json
@@ -8,6 +8,8 @@
     "double-conversion",
     "eigen3",
     "expat",
+    "exprtk",
+    "fmt",
     "freetype",
     "glew",
     {
@@ -32,11 +34,8 @@
     "pugixml",
     "sqlite3",
     "tiff",
-    "utfcpp",
-    "exprtk",
-    "fmt",
     "trilinos",
-    "verdict",
+    "utfcpp",
     {
       "name": "vcpkg-cmake",
       "host": true
@@ -45,6 +44,7 @@
       "name": "vcpkg-cmake-config",
       "host": true
     },
+    "verdict",
     "zlib"
   ],
   "features": {
@@ -145,6 +145,7 @@
     "paraview": {
       "description": "Build vtk modules required by paraview",
       "dependencies": [
+        "cli11",
         {
           "name": "vtk",
           "default-features": false,
@@ -152,7 +153,6 @@
             "qt"
           ]
         },
-        "cli11",
         {
           "name": "vtk",
           "default-features": false,
@@ -172,9 +172,9 @@
     "qt": {
       "description": "Qt functionality for VTK",
       "dependencies": [
+        "qt5-declarative",
         "qt5-imageformats",
         "qt5-tools",
-        "qt5-declarative",
         {
           "name": "qt5-x11extras",
           "platform": "linux"
PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for netcdf-c have changed but the version was not updated
version: 4.8.1#2
old SHA: f4d487e2f7e093b2406887023bb3a0856735bad5
new SHA: eb77e4fa2d8639e5ce131ed4839047f19d3dbeb9
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for cgns have changed but the version was not updated
version: 4.3.0#1
old SHA: 1733a3011caebf67ccbe1d48ea08c92e87d186e0
new SHA: cd09f67eea6c4dfd1430f04aedd3eb1ab12bd557
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for hdf5 have changed but the version was not updated
version: 1.12.2#3
old SHA: 49bd00fad1be159f72151186015b20bf095f4177
new SHA: c1b7be3bcdb47053033d42216a40883843d9c05a
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 4cb4a5c5ddcb9de0c83c85837ee6974c8333f032 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 8c455bfb..043377a8 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5677,8 +5677,8 @@
       "port-version": 1
     },
     "paraview": {
-      "baseline": "5.9.1",
-      "port-version": 2
+      "baseline": "5.11.0",
+      "port-version": 0
     },
     "parmetis": {
       "baseline": "2022-07-27",
@@ -7584,6 +7584,10 @@
       "baseline": "1.6",
       "port-version": 2
     },
+    "trilinos": {
+      "baseline": "13.4.1+20221112",
+      "port-version": 0
+    },
     "triton": {
       "baseline": "0.9",
       "port-version": 5
@@ -7840,6 +7844,10 @@
       "baseline": "2.02.00",
       "port-version": 0
     },
+    "verdict": {
+      "baseline": "1.4.0",
+      "port-version": 0
+    },
     "visit-struct": {
       "baseline": "1.0",
       "port-version": 2
@@ -7873,16 +7881,16 @@
       "port-version": 1
     },
     "vtk": {
-      "baseline": "9.0.3-pv5.9.1",
-      "port-version": 12
+      "baseline": "9.2.0-pv5.11.0",
+      "port-version": 0
     },
     "vtk-dicom": {
       "baseline": "0.8.12",
       "port-version": 2
     },
     "vtk-m": {
-      "baseline": "1.6.0",
-      "port-version": 2
+      "baseline": "1.9.0",
+      "port-version": 0
     },
     "vulkan": {
       "baseline": "1.1.82.1",
diff --git a/versions/p-/paraview.json b/versions/p-/paraview.json
index 91d43f8c..0a69e1d9 100644
--- a/versions/p-/paraview.json
+++ b/versions/p-/paraview.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "a9528d9364233026f84f93ac54be5594cf2fb460",
+      "version": "5.11.0",
+      "port-version": 0
+    },
     {
       "git-tree": "8f5d22c6754f293f54a360472f78e760f06aae80",
       "version": "5.9.1",
diff --git a/versions/v-/vtk-m.json b/versions/v-/vtk-m.json
index d96689fa..9b39d767 100644
--- a/versions/v-/vtk-m.json
+++ b/versions/v-/vtk-m.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "50168acdf8fd4847749564a76e27292c73d4faca",
+      "version-semver": "1.9.0",
+      "port-version": 0
+    },
     {
       "git-tree": "bfd540dbdb5d0684ea4e5363e3b32cfceadcb542",
       "version-semver": "1.6.0",
diff --git a/versions/v-/vtk.json b/versions/v-/vtk.json
index 5423109b..c9727585 100644
--- a/versions/v-/vtk.json
+++ b/versions/v-/vtk.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "36e5538dd2ed8aff4aee69dfc5896aa638b1efd8",
+      "version-semver": "9.2.0-pv5.11.0",
+      "port-version": 0
+    },
     {
       "git-tree": "64cd3c51764272ed1c8acc2d5fa37106d9f76b66",
       "version-semver": "9.0.3-pv5.9.1",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/paraview/portfile.cmake
  • ports/vtk/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/vtk-m/vcpkg.json

Valid values for the license field can be found in the documentation

@Cheney-W Cheney-W removed the info:reviewed Pull Request changes follow basic guidelines label Jan 9, 2023
# Conflicts:
#	ports/rtabmap/vcpkg.json
#	versions/baseline.json
#	versions/h-/hdf5.json
#	versions/o-/openimageio.json
#	versions/r-/rtabmap.json
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for theia have changed but the version was not updated
version: 0.8#7
old SHA: e8a6f763efb9bd7657a6be700493a95ab32d1cb6
new SHA: 4480741745f0449e1d70ac48c9fcec6b187a1c55
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 877e3dc2323a4d4c3c75e7168c22a0c4e921d4db -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 058c0129..cb068cef 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1394,7 +1394,7 @@
     },
     "cgns": {
       "baseline": "4.3.0",
-      "port-version": 2
+      "port-version": 3
     },
     "chaiscript": {
       "baseline": "6.1.0",
@@ -2934,7 +2934,7 @@
     },
     "hdf5": {
       "baseline": "1.12.2",
-      "port-version": 4
+      "port-version": 5
     },
     "healpix": {
       "baseline": "1.12.10",
@@ -4850,7 +4850,7 @@
     },
     "matio": {
       "baseline": "1.5.23",
-      "port-version": 0
+      "port-version": 1
     },
     "matplotlib-cpp": {
       "baseline": "2020-08-27",
@@ -5574,7 +5574,7 @@
     },
     "opencv4": {
       "baseline": "4.6.0",
-      "port-version": 10
+      "port-version": 11
     },
     "opendnp3": {
       "baseline": "3.1.1",
@@ -5606,7 +5606,7 @@
     },
     "openimageio": {
       "baseline": "2.4.5.0",
-      "port-version": 1
+      "port-version": 2
     },
     "openjpeg": {
       "baseline": "2.5.0",
@@ -5785,8 +5785,8 @@
       "port-version": 1
     },
     "paraview": {
-      "baseline": "5.9.1",
-      "port-version": 2
+      "baseline": "5.11.0",
+      "port-version": 0
     },
     "parmetis": {
       "baseline": "2022-07-27",
@@ -6802,7 +6802,7 @@
     },
     "rtabmap": {
       "baseline": "0.20.16",
-      "port-version": 0
+      "port-version": 1
     },
     "rtaudio": {
       "baseline": "2021-11-16",
@@ -6960,6 +6960,10 @@
       "baseline": "0.16.1",
       "port-version": 6
     },
+    "seacas": {
+      "baseline": "2022-11-22",
+      "port-version": 0
+    },
     "seal": {
       "baseline": "4.1.1",
       "port-version": 0
@@ -8000,6 +8004,10 @@
       "baseline": "2.02.00",
       "port-version": 0
     },
+    "verdict": {
+      "baseline": "1.4.0",
+      "port-version": 0
+    },
     "vili": {
       "baseline": "1.0.0+20221123",
       "port-version": 0
@@ -8037,16 +8045,16 @@
       "port-version": 1
     },
     "vtk": {
-      "baseline": "9.0.3-pv5.9.1",
-      "port-version": 12
+      "baseline": "9.2.0-pv5.11.0",
+      "port-version": 0
     },
     "vtk-dicom": {
       "baseline": "0.8.14",
-      "port-version": 0
+      "port-version": 1
     },
     "vtk-m": {
-      "baseline": "1.6.0",
-      "port-version": 2
+      "baseline": "1.9.0",
+      "port-version": 0
     },
     "vulkan": {
       "baseline": "1.1.82.1",
diff --git a/versions/h-/hdf5.json b/versions/h-/hdf5.json
index ec400e09..28f31a8b 100644
--- a/versions/h-/hdf5.json
+++ b/versions/h-/hdf5.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "71726aefa4830ee87043862a8541853861cd8333",
+      "version": "1.12.2",
+      "port-version": 5
+    },
     {
       "git-tree": "815c3b39b38a2cf57e33d010b6a8f9c84a178676",
       "version": "1.12.2",
diff --git a/versions/o-/openimageio.json b/versions/o-/openimageio.json
index 3a566cb1..76a8f87a 100644
--- a/versions/o-/openimageio.json
+++ b/versions/o-/openimageio.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "f9959dd6e10f7f11261c50108d4399f29d21883a",
+      "version": "2.4.5.0",
+      "port-version": 2
+    },
     {
       "git-tree": "ecd81b1df58bf0fb628ad86bfde7522e36a602e4",
       "version": "2.4.5.0",
diff --git a/versions/r-/rtabmap.json b/versions/r-/rtabmap.json
index 98369bb8..10a1de94 100644
--- a/versions/r-/rtabmap.json
+++ b/versions/r-/rtabmap.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "76fcaec671ee842145350073b384ad7943b8b361",
+      "version": "0.20.16",
+      "port-version": 1
+    },
     {
       "git-tree": "03425e1733ea172a21e79235cef0a05b9791eb10",
       "version": "0.20.16",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/paraview/portfile.cmake
  • ports/vtk/portfile.cmake

github-actions[bot]
github-actions bot previously approved these changes Jan 16, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/paraview/portfile.cmake
  • ports/vtk/portfile.cmake

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for rtabmap have changed but the version was not updated
version: 0.20.16#1
old SHA: 76fcaec671ee842145350073b384ad7943b8b361
new SHA: 7edcb59c196dd8c30de022a6eda00e127bf82e85
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/paraview/portfile.cmake
  • ports/vtk/portfile.cmake

github-actions[bot]
github-actions bot previously approved these changes Jan 17, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/paraview/portfile.cmake
  • ports/vtk/portfile.cmake

# Conflicts:
#	ports/opencv4/vcpkg.json
#	versions/baseline.json
#	versions/o-/opencv4.json
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5908d702d61cea1429b223a0b7a10ab86bad4c78 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 525e0cff..ee3e518f 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1394,7 +1394,7 @@
     },
     "cgns": {
       "baseline": "4.3.0",
-      "port-version": 2
+      "port-version": 3
     },
     "chaiscript": {
       "baseline": "6.1.0",
@@ -2934,7 +2934,7 @@
     },
     "hdf5": {
       "baseline": "1.12.2",
-      "port-version": 4
+      "port-version": 5
     },
     "healpix": {
       "baseline": "1.12.10",
@@ -4850,7 +4850,7 @@
     },
     "matio": {
       "baseline": "1.5.23",
-      "port-version": 0
+      "port-version": 1
     },
     "matplotlib-cpp": {
       "baseline": "2020-08-27",
@@ -5606,7 +5606,7 @@
     },
     "openimageio": {
       "baseline": "2.4.5.0",
-      "port-version": 1
+      "port-version": 2
     },
     "openjpeg": {
       "baseline": "2.5.0",
@@ -5785,8 +5785,8 @@
       "port-version": 1
     },
     "paraview": {
-      "baseline": "5.9.1",
-      "port-version": 2
+      "baseline": "5.11.0",
+      "port-version": 0
     },
     "parmetis": {
       "baseline": "2022-07-27",
@@ -6960,6 +6960,10 @@
       "baseline": "0.16.1",
       "port-version": 6
     },
+    "seacas": {
+      "baseline": "2022-11-22",
+      "port-version": 0
+    },
     "seal": {
       "baseline": "4.1.1",
       "port-version": 0
@@ -8000,6 +8004,10 @@
       "baseline": "2.02.00",
       "port-version": 0
     },
+    "verdict": {
+      "baseline": "1.4.0",
+      "port-version": 0
+    },
     "vili": {
       "baseline": "1.0.0+20221123",
       "port-version": 0
@@ -8037,16 +8045,16 @@
       "port-version": 1
     },
     "vtk": {
-      "baseline": "9.0.3-pv5.9.1",
-      "port-version": 12
+      "baseline": "9.2.0-pv5.11.0",
+      "port-version": 0
     },
     "vtk-dicom": {
       "baseline": "0.8.14",
-      "port-version": 0
+      "port-version": 1
     },
     "vtk-m": {
-      "baseline": "1.6.0",
-      "port-version": 2
+      "baseline": "1.9.0",
+      "port-version": 0
     },
     "vulkan": {
       "baseline": "1.1.82.1",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/paraview/portfile.cmake
  • ports/vtk/portfile.cmake

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/paraview/portfile.cmake
  • ports/vtk/portfile.cmake

Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neumann-A
Copy link
Contributor Author

@vicroms reviewed tag ?

@vicroms vicroms added the info:reviewed Pull Request changes follow basic guidelines label Jan 18, 2023
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am super not a fan of merging seacas in the condition where there are more than a thousand lines of not submitted to upstream patches, and it would be better to add these new paraview features as their own PR rather than as an update like this. However, I understand you've been jerked around here a lot by merge conflicts and stuff and the changes seem ... at least reasonable, so I'm going to merge this.

Please do look at submitting the seacas changes upstream.

seacas:

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx

I wasn't really able to verify this; unfortunately "find_package" is named over 200 times in this port. Most of the examples I found did say REQUIRED so I'm willing to take your word for it for now

  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See docs/examples/adding-an-explicit-usage.md for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

verdict

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See docs/examples/adding-an-explicit-usage.md for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Comment on lines +7 to +10
PATCHES fix_tpl_libs.patch
fix-ioss-includes.patch
deps-and-shared.patch
fix-mpi.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really Really not a fan of the amount of patching going on here. Is there a reason this needs to support being built as a DLL if upstream does not care? I would really like to see it submitted upstream at a minimum.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as I can tell from the gitblame the DLL stuff in seacas was upstreamed by mathstuf for VTK but only for the without MPI case. This is probably due to the case that MPI in conjunction with os windows is found rarely.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VTK vendoring probably doesn't enable the MPI support, so it was hidden from my patching. FWIW, -fvisibility=hidden would show the same problem(s) on Linux and macOS if anyone wants to track it down (I suspect VTK might want MPI-aware IOSS at some point, so "me" is certainly a possible answer there).

vcpkg_cmake_configure(
SOURCE_PATH "${SOURCE_PATH}"
OPTIONS
#--trace-expand
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#--trace-expand

Comment on lines +69 to +70
#"-DCGNS_ALLOW_PREDEFIND:BOOL=NO"
#"-DSeacas_ENABLE_ALL_PACKAGES:BOOL=ON"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#"-DCGNS_ALLOW_PREDEFIND:BOOL=NO"
#"-DSeacas_ENABLE_ALL_PACKAGES:BOOL=ON"

@BillyONeal BillyONeal merged commit 9e36a44 into microsoft:master Jan 20, 2023
@Neumann-A Neumann-A deleted the update-paraview branch January 20, 2023 06:17
@petersteneteg
Copy link
Contributor

Great work!!! thanks so much for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[paraview] update to v5.10.1