Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ceres and SuiteSparse features #2800

Merged
merged 3 commits into from
Feb 17, 2018

Conversation

KindDragon
Copy link
Contributor

No description provided.

@jasjuang
Copy link
Contributor

I tested this and everything compiles like usual for me

@KindDragon
Copy link
Contributor Author

@jasjuang You mean everything ok or everything compiles even if you trying to install ceres[core]? :)

@jasjuang
Copy link
Contributor

I tested vcpkg install ceres and vcpkg install ceres[lapack,suitesparse, cxsparse, eigen] and both works

@ras0219-msft ras0219-msft merged commit 18be859 into microsoft:master Feb 17, 2018
@ras0219-msft
Copy link
Contributor

Thanks! While testing, I noticed that eigen was actually called at the top level like:

find_package(Eigen3 REQUIRED)

so I've lifted that requirement up to the top of the package.

@KindDragon KindDragon deleted the ceres-features branch February 17, 2018 13:42
@KindDragon KindDragon restored the ceres-features branch February 19, 2018 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants