[egl] Revise wrapper and pkgconfig files for windows #28174
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| find_package(unofficial-angle CONFIG) | ||
| if(TARGET unofficial::angle::libEGL) | ||
| set(EGL_LIBRARY unofficial::angle::libEGL) | ||
| if(NOT TARGET EGL::EGL) | ||
| add_library(EGL::EGL INTERFACE IMPORTED) | ||
| set_target_properties(EGL::EGL PROPERTIES | ||
| INTERFACE_LINK_LIBRARIES unofficial::angle::libEGL | ||
| ) | ||
| endif() |
There was a problem hiding this comment.
Please don't depend on unofficial targets. I expect it to go away as soon as angle gets changed to actually use the upstream buildsystem and having unofficial targets be used downstream is always a migration blocker.
There was a problem hiding this comment.
This dependency is internal (within the wrapper). I consider this less harmful than external usage of unofficial packages and than redundant information about link libraries. We can always silently provide the unofficial targets for a transition period, purely forwarding to the official targets.
I'm not sure if I know enough about angle. AFAIU its native build system is gn. Where do I find the official targets it is going to provide? (I would love to know the same about skia.)
There was a problem hiding this comment.
Since it is not using cmake it won't provide any official targets and you have to use find_library to setup targets.
There was a problem hiding this comment.
So this is why we do use unofficial targets, internally: Encode usage requirements in the port where they come from, not where they are used.
There was a problem hiding this comment.
Encode usage requirements in the port where they come from, not where they are used.
Then you have to apply that logic also to the pc file.....
JonLiu1993
added
the
category:port-bug
|
Keep in mind that EGL could also come from mesa. I just blessed ANGLE because EGL via DX seemed more appropriate/useable than EGL via software. |
What does your PR fix?
Fixes filename case mismatch for mingw in pc file (assuming case-insensitive filesystem for Windows hosts, as usual).
Simplifies the wrapper based on unofficial angle config.
Fixes unintented side effect on
CMAKE_REQUIRED_<variable>(cf. [baseline][osg] Prefer GLVND libraries #28089 (comment)).Which triplets are supported/not supported? Have you updated the CI baseline?
unchanged
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes