Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[double-conversion] Update to 3.2.1 #28242

Merged
merged 7 commits into from
Dec 12, 2022

Conversation

Neumann-A
Copy link
Contributor

No description provided.

github-actions[bot]
github-actions bot previously approved these changes Dec 8, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/double-conversion/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/double-conversion/vcpkg.json

Valid values for the license field can be found in the documentation

@@ -1,10 +1,8 @@
vcpkg_check_linkage(ONLY_STATIC_LIBRARY)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port is using CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS which could be a problem but upstream intends to support dynamic build via this mechanism. If it doesn't work upstream should probably be informed about that.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 30a20e8f15ff26eec665205dea52f4ffc6f0814b -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 9f14f19..31c26ff 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3154,7 +3154,7 @@
     },
     "itk": {
       "baseline": "5.2.1",
-      "port-version": 2
+      "port-version": 3
     },
     "itpp": {
       "baseline": "4.3.1",
diff --git a/versions/i-/itk.json b/versions/i-/itk.json
index 76bb7db..b59721d 100644
--- a/versions/i-/itk.json
+++ b/versions/i-/itk.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "08b53e56ab5cc75f6ad268c0b2f2ee2643142a7e",
+      "version": "5.2.1",
+      "port-version": 3
+    },
     {
       "git-tree": "e22b353e8f00bcdc12b78d414a712a3498a2d0d6",
       "version": "5.2.1",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/double-conversion/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/double-conversion/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Dec 8, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/double-conversion/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/double-conversion/vcpkg.json

Valid values for the license field can be found in the documentation

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Dec 9, 2022
@JonLiu1993
Copy link
Member

@Neumann-A, Thanks for your pr, please get the ci error:

FAILED: bin/itkTestDriver.exe 
cmd.exe /C "cd . && D:\downloads\tools\cmake-3.25.0-windows\cmake-3.25.0-windows-i386\bin\cmake.exe -E vs_link_exe --intdir=Modules\Core\TestKernel\src\CMakeFiles\itkTestDriver.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\mt.exe --manifests  -- C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1434~1.319\bin\Hostx64\x64\link.exe  Modules\Core\TestKernel\src\CMakeFiles\itkTestDriver.dir\itkTestDriver.cxx.obj  /out:bin\itkTestDriver.exe /implib:lib\itkTestDriver.lib /pdb:bin\itkTestDriver.pdb /version:0.0 /machine:x64  /nologo    /debug /INCREMENTAL /subsystem:console -LIBPATH:D:\installed\x64-windows-static\lib lib\ITKIOBMP-5.3.lib  lib\ITKIOGDCM-5.3.lib  lib\ITKIOGIPL-5.3.lib  lib\ITKIOJPEG-5.3.lib  lib\ITKIOMeshBYU-5.3.lib  lib\ITKIOMeshFreeSurfer-5.3.lib  lib\ITKIOMeshGifti-5.3.lib  lib\ITKIOMeshOBJ-5.3.lib  lib\ITKIOMeshOFF-5.3.lib  lib\ITKIOMeshVTK-5.3.lib  lib\ITKIOMeta-5.3.lib  lib\ITKIONIFTI-5.3.lib  lib\ITKIONRRD-5.3.lib  lib\ITKIOPNG-5.3.lib  lib\ITKIOTIFF-5.3.lib  lib\ITKIOVTK-5.3.lib  lib\ITKCommon-5.3.lib  lib\ITKIOImageBase-5.3.lib  lib\ITKTestKernel-5.3.lib  lib\ITKIOBMP-5.3.lib  lib\ITKIOGDCM-5.3.lib  D:\installed\x64-windows-static\debug\lib\gdcmMSFF.lib  D:\installed\x64-windows-static\debug\lib\gdcmDICT.lib  D:\installed\x64-windows-static\debug\lib\gdcmIOD.lib  D:\installed\x64-windows-static\debug\lib\gdcmDSED.lib  D:\installed\x64-windows-static\debug\lib\gdcmCommon.lib  crypt32.lib  D:\installed\x64-windows-static\debug\lib\gdcmjpeg8.lib  D:\installed\x64-windows-static\debug\lib\gdcmjpeg12.lib  D:\installed\x64-windows-static\debug\lib\gdcmjpeg16.lib  D:\installed\x64-windows-static\debug\lib\openjp2.lib  D:\installed\x64-windows-static\debug\lib\gdcmcharls.lib  rpcrt4.lib  lib\ITKIOGIPL-5.3.lib  lib\ITKIOJPEG-5.3.lib  lib\ITKIOMeshBYU-5.3.lib  lib\ITKIOMeshFreeSurfer-5.3.lib  lib\ITKIOMeshGifti-5.3.lib  lib\ITKgiftiio-5.3.lib  D:\installed\x64-windows-static\debug\lib\libexpatdMT.lib  lib\ITKIOMeshOBJ-5.3.lib  lib\ITKIOMeshOFF-5.3.lib  lib\ITKIOMeshVTK-5.3.lib  lib\ITKIOMeshBase-5.3.lib  lib\ITKQuadEdgeMesh-5.3.lib  lib\ITKMesh-5.3.lib  lib\ITKIOMeta-5.3.lib  lib\ITKMetaIO-5.3.lib  comctl32.lib  wsock32.lib  lib\ITKIONIFTI-5.3.lib  lib\ITKniftiio-5.3.lib  lib\ITKznz-5.3.lib  lib\ITKTransform-5.3.lib  lib\ITKIONRRD-5.3.lib  lib\ITKNrrdIO-5.3.lib  lib\ITKIOPNG-5.3.lib  D:\installed\x64-windows-static\debug\lib\libpng16d.lib  lib\ITKIOTIFF-5.3.lib  D:\installed\x64-windows-static\debug\lib\tiffd.lib  D:\installed\x64-windows-static\debug\lib\lzma.lib  D:\installed\x64-windows-static\debug\lib\zlibd.lib  D:\installed\x64-windows-static\debug\lib\jpeg.lib  lib\ITKIOVTK-5.3.lib  lib\ITKIOImageBase-5.3.lib  lib\ITKCommon-5.3.lib  D:\installed\x64-windows-static\lib\double-conversion.lib  lib\itksys-5.3.lib  ws2_32.lib  dbghelp.lib  psapi.lib  lib\ITKVNLInstantiation-5.3.lib  lib\itkvnl_algo-5.3.lib  lib\itkvnl-5.3.lib  lib\itkv3p_netlib-5.3.lib  lib\itkvcl-5.3.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
LINK Pass 1: command "C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1434~1.319\bin\Hostx64\x64\link.exe Modules\Core\TestKernel\src\CMakeFiles\itkTestDriver.dir\itkTestDriver.cxx.obj /out:bin\itkTestDriver.exe /implib:lib\itkTestDriver.lib /pdb:bin\itkTestDriver.pdb /version:0.0 /machine:x64 /nologo /debug /INCREMENTAL /subsystem:console -LIBPATH:D:\installed\x64-windows-static\lib lib\ITKIOBMP-5.3.lib lib\ITKIOGDCM-5.3.lib lib\ITKIOGIPL-5.3.lib lib\ITKIOJPEG-5.3.lib lib\ITKIOMeshBYU-5.3.lib lib\ITKIOMeshFreeSurfer-5.3.lib lib\ITKIOMeshGifti-5.3.lib lib\ITKIOMeshOBJ-5.3.lib lib\ITKIOMeshOFF-5.3.lib lib\ITKIOMeshVTK-5.3.lib lib\ITKIOMeta-5.3.lib lib\ITKIONIFTI-5.3.lib lib\ITKIONRRD-5.3.lib lib\ITKIOPNG-5.3.lib lib\ITKIOTIFF-5.3.lib lib\ITKIOVTK-5.3.lib lib\ITKCommon-5.3.lib lib\ITKIOImageBase-5.3.lib lib\ITKTestKernel-5.3.lib lib\ITKIOBMP-5.3.lib lib\ITKIOGDCM-5.3.lib D:\installed\x64-windows-static\debug\lib\gdcmMSFF.lib D:\installed\x64-windows-static\debug\lib\gdcmDICT.lib D:\installed\x64-windows-static\debug\lib\gdcmIOD.lib D:\installed\x64-windows-static\debug\lib\gdcmDSED.lib D:\installed\x64-windows-static\debug\lib\gdcmCommon.lib crypt32.lib D:\installed\x64-windows-static\debug\lib\gdcmjpeg8.lib D:\installed\x64-windows-static\debug\lib\gdcmjpeg12.lib D:\installed\x64-windows-static\debug\lib\gdcmjpeg16.lib D:\installed\x64-windows-static\debug\lib\openjp2.lib D:\installed\x64-windows-static\debug\lib\gdcmcharls.lib rpcrt4.lib lib\ITKIOGIPL-5.3.lib lib\ITKIOJPEG-5.3.lib lib\ITKIOMeshBYU-5.3.lib lib\ITKIOMeshFreeSurfer-5.3.lib lib\ITKIOMeshGifti-5.3.lib lib\ITKgiftiio-5.3.lib D:\installed\x64-windows-static\debug\lib\libexpatdMT.lib lib\ITKIOMeshOBJ-5.3.lib lib\ITKIOMeshOFF-5.3.lib lib\ITKIOMeshVTK-5.3.lib lib\ITKIOMeshBase-5.3.lib lib\ITKQuadEdgeMesh-5.3.lib lib\ITKMesh-5.3.lib lib\ITKIOMeta-5.3.lib lib\ITKMetaIO-5.3.lib comctl32.lib wsock32.lib lib\ITKIONIFTI-5.3.lib lib\ITKniftiio-5.3.lib lib\ITKznz-5.3.lib lib\ITKTransform-5.3.lib lib\ITKIONRRD-5.3.lib lib\ITKNrrdIO-5.3.lib lib\ITKIOPNG-5.3.lib D:\installed\x64-windows-static\debug\lib\libpng16d.lib lib\ITKIOTIFF-5.3.lib D:\installed\x64-windows-static\debug\lib\tiffd.lib D:\installed\x64-windows-static\debug\lib\lzma.lib D:\installed\x64-windows-static\debug\lib\zlibd.lib D:\installed\x64-windows-static\debug\lib\jpeg.lib lib\ITKIOVTK-5.3.lib lib\ITKIOImageBase-5.3.lib lib\ITKCommon-5.3.lib D:\installed\x64-windows-static\lib\double-conversion.lib lib\itksys-5.3.lib ws2_32.lib dbghelp.lib psapi.lib lib\ITKVNLInstantiation-5.3.lib lib\itkvnl_algo-5.3.lib lib\itkvnl-5.3.lib lib\itkv3p_netlib-5.3.lib lib\itkvcl-5.3.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:Modules\Core\TestKernel\src\CMakeFiles\itkTestDriver.dir/intermediate.manifest Modules\Core\TestKernel\src\CMakeFiles\itkTestDriver.dir/manifest.res" failed (exit code 1319) with the following output:
double-conversion.lib(double-to-string.cc.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '0' doesn't match value '2' in itkTestDriver.cxx.obj
double-conversion.lib(double-to-string.cc.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MTd_StaticDebug' in itkTestDriver.cxx.obj
double-conversion.lib(bignum-dtoa.cc.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '0' doesn't match value '2' in itkTestDriver.cxx.obj
double-conversion.lib(bignum-dtoa.cc.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MTd_StaticDebug' in itkTestDriver.cxx.obj
double-conversion.lib(fixed-dtoa.cc.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '0' doesn't match value '2' in itkTestDriver.cxx.obj
double-conversion.lib(fixed-dtoa.cc.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MTd_StaticDebug' in itkTestDriver.cxx.obj
double-conversion.lib(bignum.cc.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '0' doesn't match value '2' in itkTestDriver.cxx.obj
double-conversion.lib(bignum.cc.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MTd_StaticDebug' in itkTestDriver.cxx.obj
double-conversion.lib(cached-powers.cc.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '0' doesn't match value '2' in itkTestDriver.cxx.obj

double-conversion.lib(cached-powers.cc.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MTd_StaticDebug' in itkTestDriver.cxx.obj

LIBCMTD.lib(initializers.obj) : warning LNK4098: defaultlib 'libcmt.lib' conflicts with use of other libs; use /NODEFAULTLIB:library

bin\itkTestDriver.exe : fatal error LNK1319: 10 mismatches detected

ninja: build stopped: subcommand failed.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for itk have changed but the version was not updated
version: 5.2.1#3
old SHA: 08b53e56ab5cc75f6ad268c0b2f2ee2643142a7e
new SHA: a3904d4a80201635e6687ff2b5ca5d677b559874
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/double-conversion/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/double-conversion/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for itk have changed but the version was not updated
version: 5.2.1#3
old SHA: 08b53e56ab5cc75f6ad268c0b2f2ee2643142a7e
new SHA: e0f09cb16ff5af0f901a715c9ceafb5ff78af129
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/double-conversion/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/double-conversion/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/double-conversion/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/double-conversion/vcpkg.json

Valid values for the license field can be found in the documentation

@Neumann-A
Copy link
Contributor Author

@JonLiu1993 PR is green.

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Dec 12, 2022
@dan-shaw dan-shaw merged commit 1a2b03e into microsoft:master Dec 12, 2022
@Neumann-A Neumann-A deleted the update_double_conversion branch December 12, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants