[qtbase] make double-conversion a hard dependency #28245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
The required functionality can be part of |
|
https://nxmnpg.lemoda.net/3/sscanf_l
So it seems like they should be available on OSX. Maybe the configure check for |
Neumann-A
reviewed
Dec 8, 2022
Hm they are available, but when I try to build qtbase[core] I get
|
Probably, the code is marked with |
|
So I can leave the feature but make it a hard dependency until the qt folks fixed their configure checks. |
autoantwort
force-pushed
the
qtbase-always-double-conversion
branch
from
27c22f7
to
7643561
Compare
you could probably fix it faster ;) |
Neumann-A
reviewed
Dec 8, 2022
| @@ -22,8 +22,7 @@ | |||
| "default-features": false, | |||
| "features": [ | |||
| "doubleconversion" | |||
| ], | |||
| "platform": "windows" | |||
There was a problem hiding this comment.
"platform": "!osx & !freebsd" ? That is what upstream claims indirectly. I think that should be reflected here. I know that it is annoying for osx but if it is not annoying nobody will fix it ;)
There was a problem hiding this comment.
Yeah we can use that if the config check is fixed.
LilyWangLL
added
the
category:port-bug
|
It seems that |
The config check in qtbase is currently broken so that double-conversion is always required
autoantwort
force-pushed
the
qtbase-always-double-conversion
branch
from
7643561
to
ad09eff
Compare
LilyWangLL
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
double-conversion is needed at all major platforms (linux, osx, windows), otherwise the configure step will fail