-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg baseline][ideviceinstaller] Fixing error LNK2005: optind already defined in darknet.lib #28718
Conversation
I will fix it also upstream. Would you mind a PR over there, so that I can merge it faster? |
@cenit Is the upstream you mentioned darknet? |
yes, github.com/alexeyab/darknet |
I'm not sure if these changes should be applied to upstream, since it involves using the getopt provided by vcpkg, and we have no right to require upstrem to use the port installed via vcpkg. |
Upstream probably needs to mangle the symbols so that they are not conflicting with others. |
I am one of the only two people with write access to upstream repo :D |
IMO getopt simply doesn't belong into the library. It needs to be separate, linked to or compiled into executables. |
Describe the pull request
What does your PR fix?
Fixes
ideviceinstaller:x64-windows-static
install failed with error LNK2005: optind already defined in darknet.lib.This issue is a CI baseline issue from https://dev.azure.com/vcpkg/public/_build/results?buildId=83095&view=results