Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][ideviceinstaller] Fixing error LNK2005: optind already defined in darknet.lib #28718

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

Cheney-W
Copy link
Contributor

@Cheney-W Cheney-W commented Jan 4, 2023

Describe the pull request

@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 4, 2023
@Cheney-W Cheney-W marked this pull request as ready for review January 5, 2023 02:06
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 5, 2023
@vicroms vicroms merged commit 35ca0b2 into microsoft:master Jan 5, 2023
@Cheney-W Cheney-W deleted the Dev/Cheney/baseline branch January 6, 2023 02:23
@cenit
Copy link
Contributor

cenit commented Jan 8, 2023

I will fix it also upstream. Would you mind a PR over there, so that I can merge it faster?

@Cheney-W
Copy link
Contributor Author

Cheney-W commented Jan 9, 2023

@cenit Is the upstream you mentioned darknet?

@cenit
Copy link
Contributor

cenit commented Jan 9, 2023

yes, github.com/alexeyab/darknet

@Cheney-W
Copy link
Contributor Author

Cheney-W commented Jan 9, 2023

I'm not sure if these changes should be applied to upstream, since it involves using the getopt provided by vcpkg, and we have no right to require upstrem to use the port installed via vcpkg.

@Neumann-A
Copy link
Contributor

I'm not sure if these changes should be applied to upstream, since it involves using the getopt provided by vcpkg, and we have no right to require upstrem to use the port installed via vcpkg.

Upstream probably needs to mangle the symbols so that they are not conflicting with others.

@cenit
Copy link
Contributor

cenit commented Jan 9, 2023

I am one of the only two people with write access to upstream repo :D
We are very well integrated with vcpkg, but of course the PR should be managed so that people not using it can still have a working copy.
If it's too much hassle for you, I'll do it sooner or later, so that the patch here will become redundant

@dg0yt
Copy link
Contributor

dg0yt commented Jan 9, 2023

IMO getopt simply doesn't belong into the library. It needs to be separate, linked to or compiled into executables.
I didn't even find usage of it, but I didn't search too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants