Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libcsv,hashids] Add new port #28828

Merged
merged 9 commits into from
Jan 13, 2023
Merged

[libcsv,hashids] Add new port #28828

merged 9 commits into from
Jan 13, 2023

Conversation

emazv72
Copy link
Contributor

@emazv72 emazv72 commented Jan 9, 2023

  • What does your PR fix?

    Add new port

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all , No

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

@emazv72
Copy link
Contributor Author

emazv72 commented Jan 9, 2023

@microsoft-github-policy-service agree

@FrankXie05 FrankXie05 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 10, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libcsv have changed but the version was not updated
version: 3.0.3
old SHA: 1e7ee57baa5f8b98717ae6d2821af186632c2c4d
new SHA: e2a7a1d6f1b479c763c027ec59eb29f6b0634d0c
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libcsv/vcpkg.json

Valid values for the license field can be found in the documentation

FrankXie05
FrankXie05 previously approved these changes Jan 10, 2023
ports/libcsv/vcpkg.json Outdated Show resolved Hide resolved
@emazv72 emazv72 changed the title libcsv port libcsv & hashids port Jan 10, 2023
@emazv72 emazv72 changed the title libcsv & hashids port [libcsv,hashids] Add new port Jan 10, 2023
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Jan 13, 2023
@vicroms vicroms merged commit 44a4a76 into microsoft:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants