-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rkcommon] add new port #29263
Merged
Merged
[rkcommon] add new port #29263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonicaLiu0311
added
the
category:new-port
The issue is requesting a new library to be added; consider making a PR!
label
Jan 30, 2023
The usage test passes:
|
MonicaLiu0311
previously approved these changes
Jan 31, 2023
MonicaLiu0311
added
the
info:reviewed
Pull Request changes follow basic guidelines
label
Jan 31, 2023
I manually checked that the SHA in here is not affected by #29288 |
BillyONeal
dismissed stale reviews from MonicaLiu0311 and github-actions[bot]
via
February 1, 2023 02:48
6a9d998
BillyONeal
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new port @Neumann-A !
Thanks for checking the usage @MonicaLiu0311 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:new-port
The issue is requesting a new library to be added; consider making a PR!
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes comply with the maintainer guideOptional dependencies are resolved in exactly one way. For example, if the component is built with CMake, allNonefind_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled withCMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.