Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rkcommon] add new port #29263

Merged
merged 7 commits into from
Feb 1, 2023
Merged

[rkcommon] add new port #29263

merged 7 commits into from
Feb 1, 2023

Conversation

Neumann-A
Copy link
Contributor

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled withCMAKE_DISABLE_FIND_PACKAGE_Xxx None
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See docs/examples/adding-an-explicit-usage.md for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

github-actions[bot]
github-actions bot previously approved these changes Jan 29, 2023
@MonicaLiu0311 MonicaLiu0311 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 30, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 30, 2023
@MonicaLiu0311
Copy link
Contributor

The usage test passes:

rkcommon provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(rkcommon CONFIG REQUIRED)
    target_link_libraries(main PRIVATE rkcommon::rkcommon)

MonicaLiu0311
MonicaLiu0311 previously approved these changes Jan 31, 2023
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Jan 31, 2023
@BillyONeal
Copy link
Member

I manually checked that the SHA in here is not affected by #29288

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new port @Neumann-A !
Thanks for checking the usage @MonicaLiu0311 !

@BillyONeal BillyONeal merged commit a4e94e9 into microsoft:master Feb 1, 2023
@Neumann-A Neumann-A deleted the add_rkcommon branch February 1, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants