Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cachelib] add new facebook cachelib port #29973

Merged
merged 9 commits into from
Mar 20, 2023

Conversation

gavxin
Copy link
Contributor

@gavxin gavxin commented Mar 2, 2023

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.

The cachelib on https://repology.org/ does not match, which is a python package.

  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@gavxin gavxin marked this pull request as ready for review March 2, 2023 16:10
@jimwang118 jimwang118 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 3, 2023
ports/cachelib/fix-build.patch Outdated Show resolved Hide resolved
ports/cachelib/fix-build.patch Outdated Show resolved Hide resolved
ports/cachelib/portfile.cmake Outdated Show resolved Hide resolved
ports/cachelib/portfile.cmake Outdated Show resolved Hide resolved
ports/cachelib/vcpkg.json Outdated Show resolved Hide resolved
jimwang118
jimwang118 previously approved these changes Mar 3, 2023
ports/cachelib/portfile.cmake Outdated Show resolved Hide resolved
ports/cachelib/portfile.cmake Outdated Show resolved Hide resolved
@dg0yt
Copy link
Contributor

dg0yt commented Mar 4, 2023

The cachelib on https://repology.org/ does not match, which is a python package.

https://repology.org/projects/?search=cachelib
The python package is a separate one for most repositories: python:cachelib
cachelib is the facebook lib for the Fedora repository. Debian, Ubuntu, Kali and Raspian are listed with the python package but I assume it is an error. repology/repology-rules#684

@gavxin gavxin changed the title [cachelib] add new unofficial facebook cachelib port [cachelib] add new facebook cachelib port Mar 4, 2023
@gavxin gavxin requested review from dg0yt and removed request for jimwang118 March 7, 2023 05:01
@jimwang118
Copy link
Contributor

I have the following error when installing and testing, please fix the installation error.

/data/cache/vcpkg/buildtrees/cachelib/src/3.02.27.00-fc5b057a08.clean/cachelib/../cachelib/shm/ShmCommon.h:18:10: fatal error: numa.h: No such file or directory
 #include <numa.h>
          ^~~~~~~~
compilation terminated.

@gavxin gavxin requested review from jimwang118 and removed request for dg0yt March 10, 2023 13:35
@jimwang118
Copy link
Contributor

The usage has been tested successfully locally. 

find_package()
target_link_library()

@jimwang118 jimwang118 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 13, 2023
@dan-shaw dan-shaw added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Mar 13, 2023
@gavxin gavxin requested review from dan-shaw and removed request for jimwang118 March 15, 2023 04:32
@dan-shaw dan-shaw merged commit 7d5f1f3 into microsoft:master Mar 20, 2023
@jimwang118 jimwang118 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants