Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[baseline][ngtcp2] Disable all find_package to fix configure error #30040

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

Cheney-W
Copy link
Contributor

@Cheney-W Cheney-W commented Mar 6, 2023

Fixes CI baseline issue: multiple rules generate lib/ngtcp2.lib of below port and triplets.

ngtcp2:x86-windows
ngtcp2:x64-windows
ngtcp2:x64-uwp
ngtcp2:arm64-windows

When port cunit is found, ngtcp2 will genreate the static library which output name is same with the dynamic library, which caused this issue.
Disable all the find_package since this port has no dependency declaration yet.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Mar 6, 2023
@Cheney-W Cheney-W marked this pull request as ready for review March 6, 2023 07:51
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Mar 6, 2023
@dan-shaw dan-shaw merged commit a0ff978 into microsoft:master Mar 6, 2023
@Cheney-W Cheney-W deleted the Dev/Cheney/baseline-ngtcp2 branch March 7, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants