Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fluidsynth] Initial port #3016

Merged
merged 10 commits into from
Apr 19, 2018
Merged

[fluidsynth] Initial port #3016

merged 10 commits into from
Apr 19, 2018

Conversation

stekyne
Copy link
Contributor

@stekyne stekyne commented Mar 12, 2018

No description provided.

@ollpu
Copy link

ollpu commented Mar 19, 2018

You might want to reapply those commits on a clean copy of master to get rid of the reverted and merge commits, which would pollute history.

@stekyne
Copy link
Contributor Author

stekyne commented Mar 19, 2018

Hmm yeah I was trying to do that but obviously didn't get it right. I'll take a look again.

@heydojo
Copy link
Contributor

heydojo commented Apr 3, 2018

It would be really nice to see this merged. :) https://github.com/FluidSynth/fluidsynth/wiki/BuildingWithCMake#building-with-visual-studio-on-windows
Says it already has?

Could I please also add that it would be really nice to add the ladspa dependency to this build.
ladspa adds the chorus and reverb effects to fluidsynth which make quite a big difference to the sound output. An example of the effects in use is the application Qsynth which exposes the chorus and reverb effects to the user by default.

Cheers

@stekyne
Copy link
Contributor Author

stekyne commented Apr 3, 2018

There are feature builds in VCPKG so that could be added I'm sure. I haven't heard anything back for merging this so maybe I need to clean up the branch first. I'll try and do that soon.

@heydojo
Copy link
Contributor

heydojo commented Apr 3, 2018

Ah, I was looking at the source code again and realised how fluidsynth switches to ladspa if it is built with ladspa support (swapping the plugins.) It actually has chorus and reverb filters built in. So ladspa would be nice but it's not as important as I initially thought.

As an aside; I was able to build the latest fluidsynth code using the glib2 from vcpkg with only a tiny amount of cmake fuss on Windows 10. Works great 👍

so maybe I need to clean up the branch first.

Hmm. Maintainers might be new to git and or github or are merging code they are not building and testing themselves. All due respect to the folks at Microsoft for opening up vkpkg. Capturing open source code contributions isn't easy but it's nice to see an attempt at something Linux user space people have been doing for a very long time.

@ras0219-msft
Copy link
Contributor

Thanks for the PR and sorry for taking so long to merge!

@ras0219-msft ras0219-msft merged commit 8f08e64 into microsoft:master Apr 19, 2018
@stekyne stekyne deleted the feature/fluidsynth branch April 20, 2018 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants