-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fluidsynth] Initial port #3016
Conversation
You might want to reapply those commits on a clean copy of master to get rid of the reverted and merge commits, which would pollute history. |
Hmm yeah I was trying to do that but obviously didn't get it right. I'll take a look again. |
It would be really nice to see this merged. :) https://github.com/FluidSynth/fluidsynth/wiki/BuildingWithCMake#building-with-visual-studio-on-windows Could I please also add that it would be really nice to add the ladspa dependency to this build. Cheers |
There are feature builds in VCPKG so that could be added I'm sure. I haven't heard anything back for merging this so maybe I need to clean up the branch first. I'll try and do that soon. |
Ah, I was looking at the source code again and realised how fluidsynth switches to ladspa if it is built with ladspa support (swapping the plugins.) It actually has chorus and reverb filters built in. So ladspa would be nice but it's not as important as I initially thought. As an aside; I was able to build the latest fluidsynth code using the glib2 from vcpkg with only a tiny amount of cmake fuss on Windows 10. Works great 👍
Hmm. Maintainers might be new to git and or github or are merging code they are not building and testing themselves. All due respect to the folks at Microsoft for opening up vkpkg. Capturing open source code contributions isn't easy but it's nice to see an attempt at something Linux user space people have been doing for a very long time. |
Thanks for the PR and sorry for taking so long to merge! |
No description provided.