Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][vowpal-wabbit] Fixing conflict with string-view-lite #30377

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

Cheney-W
Copy link
Contributor

Fixes vcpkg pipeline issue vowpal-wabbit conflict with string-view-lite:

error: The following files are already installed in /mnt/vcpkg-ci/installed/x64-linux and are in conflict with vowpal-wabbit:x64-linux
Installed by string-view-lite:x64-linux    
include/nonstd/string_view.hpp

Adding -DVW_STRING_VIEW_LITE_SYS_DEP=ON to override using the submodule for string-view-lite dependency.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Mar 23, 2023
@Cheney-W Cheney-W marked this pull request as ready for review March 23, 2023 07:16
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Mar 23, 2023
@vicroms vicroms merged commit bc671eb into microsoft:master Mar 24, 2023
@Cheney-W Cheney-W deleted the Dev/Cheney/vowpal-wabbit branch March 24, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants