-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libmysql] upgrade to 8.0.32 #30576
[libmysql] upgrade to 8.0.32 #30576
Conversation
I'm wondering... Does the
Update:
|
This PR is ready for review. |
set(MYSQL_CONFIG_FILE "${CURRENT_PACKAGES_DIR}/tools/libmysql/mysql_config") | ||
vcpkg_replace_string(${MYSQL_CONFIG_FILE} "/bin/mysql_.*config" "/tools/libmysql/mysql_.*config") # try to get correct $basedir | ||
vcpkg_replace_string(${MYSQL_CONFIG_FILE} "${CURRENT_PACKAGES_DIR}" "$basedir") # use $basedir to format paths | ||
vcpkg_replace_string(${MYSQL_CONFIG_FILE} "-l\$\<\$\<CONFIG:DEBUG\>:${CURRENT_INSTALLED_DIR}/debug/lib/libz.a> " "") # remove debug version of libz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not seem correct; it's assuming that the caller is going to respect CMake generator expressions, but that's not the intended audience of this thing. If MySQL just wanted cmake to work, they'd be publishing cmake configs, not random bash scripts intended to be used like pkgconfig.
If there's no way to express the difference between release and debug here I think it would be acceptable to just pick release since that seems to be what's expected from pkgconfig-like callers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait, I'm an idiot, you're removing those :sigh:
Thanks for the update! |
./vcpkg x-add-version --all
and committing the result.