Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gtk] update to 4.10.1 #30897

Merged
merged 2 commits into from
Apr 20, 2023
Merged

[gtk] update to 4.10.1 #30897

merged 2 commits into from
Apr 20, 2023

Conversation

SchaichAlonso
Copy link
Contributor

Fixes #30896 .

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@SchaichAlonso
Copy link
Contributor Author

gtk-4.8.2 and newer no longer contain a python script to emulate meson's post-install logic, so we can't manually trigger it after patching meson not to run the post-install.

This commit patches the meson file to run the post-install even when cross-compiling, though given it's not executed when cross compiling by the upstream setup, it's execution might be optional. If all it does is to generate some caches, i.e. pollute the build system, then we might be better off not running the post-install logic at all.

Also, we now have a direct harfbuzz dependency and it also needs harfbuzz with glib support enabled.

@SchaichAlonso SchaichAlonso marked this pull request as ready for review April 16, 2023 07:46
@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 17, 2023
MonicaLiu0311
MonicaLiu0311 previously approved these changes Apr 18, 2023
View reviewed changes
@MonicaLiu0311
Copy link
Contributor

I have a doubt, what does the .typelib file do? And after installation, it is only in the lib/ directory but not in debug/lib/:

image

@MonicaLiu0311
Copy link
Contributor

And please resolve the conflict.

@SchaichAlonso
Copy link
Contributor Author

SchaichAlonso commented Apr 18, 2023 •
edited
Loading

I have a doubt, what does the .typelib file do? And after installation, it is only in the lib/ directory but not in debug/lib/:

image

Hi

Those files are databases required for gobject-introspection to work.
They've been introduced by ae826fc (i.e. they're not new, and not limited to gtk either) and an integrator / deployment setup so far needs to manually deploy these databases and then set the GI_TYPELIB_PATH environment variable to point to the location they were deployed into.

The release build's databases databases will work with a debug binary.

Eventually, gobject-introspection could be patched to emit a corresponding message.

@SchaichAlonso
[gtk] update to 4.10.1 (microsoft#30896)
3251a6f 
gtk-4.8.2 and newer no longer contain a python script to emulate meson's
post-install logic, so we can't manually trigger it after patching meson
not to run the post-install. Patch the meson file to run the post-install
even when cross-compiling, though if it's execution is optional and all
it does is to generate some caches, i.e. pollute the build system, then
we might be better off not running the post-install logic at all.

Also, we now have a direct harfbuzz dependency by gtk/gtkmain.c and
it also needs harfbuzz with glib support enabled.
@SchaichAlonso
[gtk] Regenerate version registries (microsoft#30896)
94ed8df
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Apr 20, 2023
@BillyONeal BillyONeal merged commit ec4a7d7 into microsoft:master Apr 20, 2023
@BillyONeal
Copy link
Member

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gtk] update to 4.10.1
3 participants
@SchaichAlonso @MonicaLiu0311 @BillyONeal