Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glaze] new port #30966

Merged
merged 10 commits into from
Apr 27, 2023
Merged

[glaze] new port #30966

merged 10 commits into from
Apr 27, 2023

Conversation

omarhogni
Copy link
Contributor

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@omarhogni
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Skaginn 3X ehf."

ports/glaze/portfile.cmake Outdated Show resolved Hide resolved
ports/glaze/vcpkg.json Outdated Show resolved Hide resolved
@FrankXie05 FrankXie05 added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response labels Apr 20, 2023
omarhogni and others added 4 commits April 20, 2023 09:42
Co-authored-by: Frank <65999885+FrankXie05@users.noreply.github.com>
Co-authored-by: Frank <65999885+FrankXie05@users.noreply.github.com>
ports/glaze/disable-dev-mode.patch Outdated Show resolved Hide resolved
@omarhogni
Copy link
Contributor Author

Upstream project requires at least gcc 10 the azure pipelines are built using gcc 9.

/mnt/vcpkg-ci/buildtrees/glaze/src/v1.2.1-af0f635c8a.clean/include/glaze/binary/header.hpp:7:10: fatal error: concepts: No such file or directory
    7 | #include <concepts>
      |          ^~~~~~~~~~
compilation terminated.
ninja: build stopped: subcommand failed.

What is usually done in this situation?

@FrankXie05
Copy link
Contributor

We can wait to merge until a VM update allows us to test this.

Otherwise, we can only temporarily disable the relevant functions as we cannot test it. Sorry for that. 😔

Track: microsoft/azure-pipelines-agent#3834

@dg0yt
Copy link
Contributor

dg0yt commented Apr 25, 2023

No need to wait.

What is usually done in this situation?

  • Tell port users:
    Add a message to the portfile that gcc must be at least <version>.
  • Tell vcpkg CI:
    Insert glaze:x64-linux=fail to scripts/ci.baseline.txt

Example: port coroutine.

@omarhogni
Copy link
Contributor Author

Added the following message and set pipeline failure cases as suggested by @dg0yt

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Apr 27, 2023
@BillyONeal BillyONeal merged commit ee54793 into microsoft:master Apr 27, 2023
@BillyONeal
Copy link
Member

Thanks for the new port!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants