Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[folly] fix missing dep #30973

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

autoantwort
Copy link
Contributor

Otherwise it fails with:

[28/303] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DFOLLY_XLOG_STRIP_PREFIXES=\"/Users/leanderSchulten/git_projekte/vcpkg/buildtrees/folly/src/183f5c2249-2e653483fb.clean:/Users/leanderSchulten/git_projekte/vcpkg/buildtrees/folly/arm64-osx-dbg\" -DGFLAGS_IS_A_DLL=0 -D_GNU_SOURCE -D_REENTRANT -I/Users/leanderSchulten/git_projekte/vcpkg/buildtrees/folly/src/183f5c2249-2e653483fb.clean -I/Users/leanderSchulten/git_projekte/vcpkg/buildtrees/folly/arm64-osx-dbg -I/Users/leanderSchulten/git_projekte/vcpkg/vcpkg_installed/arm64-osx/include -fPIC -g -g -Wall -Wextra -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk -g -std=gnu++1z -finput-charset=UTF-8 -fsigned-char -Wall -Wno-deprecated -Wno-deprecated-declarations -Wno-sign-compare -Wno-unused -Wuninitialized -Wunused-label -Wunused-result -Wno-noexcept-type -Wno-nullability-completeness -Wno-inconsistent-missing-override -faligned-new -std=gnu++17 -MD -MT CMakeFiles/folly_base.dir/folly/Singleton.cpp.o -MF CMakeFiles/folly_base.dir/folly/Singleton.cpp.o.d -o CMakeFiles/folly_base.dir/folly/Singleton.cpp.o -c /Users/leanderSchulten/git_projekte/vcpkg/buildtrees/folly/src/183f5c2249-2e653483fb.clean/folly/Singleton.cpp
FAILED: CMakeFiles/folly_base.dir/folly/Singleton.cpp.o 
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DFOLLY_XLOG_STRIP_PREFIXES=\"/Users/leanderSchulten/git_projekte/vcpkg/buildtrees/folly/src/183f5c2249-2e653483fb.clean:/Users/leanderSchulten/git_projekte/vcpkg/buildtrees/folly/arm64-osx-dbg\" -DGFLAGS_IS_A_DLL=0 -D_GNU_SOURCE -D_REENTRANT -I/Users/leanderSchulten/git_projekte/vcpkg/buildtrees/folly/src/183f5c2249-2e653483fb.clean -I/Users/leanderSchulten/git_projekte/vcpkg/buildtrees/folly/arm64-osx-dbg -I/Users/leanderSchulten/git_projekte/vcpkg/vcpkg_installed/arm64-osx/include -fPIC -g -g -Wall -Wextra -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk -g -std=gnu++1z -finput-charset=UTF-8 -fsigned-char -Wall -Wno-deprecated -Wno-deprecated-declarations -Wno-sign-compare -Wno-unused -Wuninitialized -Wunused-label -Wunused-result -Wno-noexcept-type -Wno-nullability-completeness -Wno-inconsistent-missing-override -faligned-new -std=gnu++17 -MD -MT CMakeFiles/folly_base.dir/folly/Singleton.cpp.o -MF CMakeFiles/folly_base.dir/folly/Singleton.cpp.o.d -o CMakeFiles/folly_base.dir/folly/Singleton.cpp.o -c /Users/leanderSchulten/git_projekte/vcpkg/buildtrees/folly/src/183f5c2249-2e653483fb.clean/folly/Singleton.cpp
In file included from /Users/leanderSchulten/git_projekte/vcpkg/buildtrees/folly/src/183f5c2249-2e653483fb.clean/folly/Singleton.cpp:35:
In file included from /Users/leanderSchulten/git_projekte/vcpkg/buildtrees/folly/src/183f5c2249-2e653483fb.clean/folly/experimental/symbolizer/Symbolizer.h:30:
/Users/leanderSchulten/git_projekte/vcpkg/buildtrees/folly/src/183f5c2249-2e653483fb.clean/folly/experimental/symbolizer/Dwarf.h:21:10: fatal error: 'boost/variant.hpp' file not found
#include <boost/variant.hpp>
         ^~~~~~~~~~~~~~~~~~~
1 error generated.

@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Apr 20, 2023
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Apr 20, 2023
@JonLiu1993
Copy link
Member

Thanks for fix this port bug.

CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:134 (message):
    Command failed: F:/test/vcpkg/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/bin/cmake.exe --build . --config Debug --target install -- -v -j9
    Working Directory: F:/test/vcpkg/buildtrees/folly/x64-windows-dbg
    See logs for more information:
      F:\test\vcpkg\buildtrees\folly\install-x64-windows-dbg-out.log

Call Stack (most recent call first):
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_build.cmake:74 (vcpkg_execute_build_process)
  installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_install.cmake:16 (vcpkg_cmake_build)
  ports/folly/portfile.cmake:69 (vcpkg_cmake_install)
  scripts/ports.cmake:147 (include)

@BillyONeal BillyONeal merged commit 829e2f5 into microsoft:master Apr 20, 2023
@BillyONeal
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants