Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boost] Remove port version constraints #31572

Merged

Conversation

JavierMatosD
Copy link
Contributor

@JavierMatosD JavierMatosD commented May 22, 2023

This PR removes port version constraints from boost ports.

I can add the port version constraints for specific ports if there is a well-understood specific requirement for that port.

Tagging @Neumann-A since you tend to work on the boost ports.

Feedback is welcome :)

This is needed for #30836 to land.

@JonLiu1993 JonLiu1993 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels May 23, 2023
@Neumann-A
Copy link
Contributor

Tagging @Neumann-A since you tend to work on the boost ports.

Not really. I basically never updated them as far as I remember. I just fixed the synchro and renaming stuff. The port version constrain probably automatically kicks in by the baseline? Is there a reason to not or to have them? You definetly will need them for the synchro update.

@Osyotr
Copy link
Contributor

Osyotr commented May 24, 2023

I guess the problem is that a change in one port requires making changes in a lot of other ports.
In practice nobody bothered update other ports so this change is ok.
What about moving dependencies from boost metaport to features and adding port version constraints to them?

@dan-shaw dan-shaw merged commit 5d3798a into microsoft:master Jun 6, 2023
@JavierMatosD JavierMatosD deleted the remove_port_version_constraints branch October 31, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants