Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tbb] added Android as supported platform #31738

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Conversation

ilya-lavrenov
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov commented May 31, 2023

@Adela0814 Adela0814 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 31, 2023
@Adela0814
Copy link
Contributor

usd test failed on CI, I will convert your PR to draft status. When you fix this error, please revert to 'Ready for Review'.
failures:

/mnt/vcpkg-ci/buildtrees/usd/src/v23.05-3a8636d7a3.clean/pxr/base/arch/align.cpp:58:12: error: use of undeclared identifier 'aligned_alloc'
/mnt/vcpkg-ci/buildtrees/usd/src/v23.05-3a8636d7a3.clean/pxr/base/arch/daemon.cpp:60:17: error: use of undeclared identifier 'NOFILE'
/mnt/vcpkg-ci/buildtrees/usd/src/v23.05-3a8636d7a3.clean/pxr/base/arch/fileSystem.cpp:908:43: error: use of undeclared identifier 'POSIX_MADV_NORMAL'
/mnt/vcpkg-ci/buildtrees/usd/src/v23.05-3a8636d7a3.clean/pxr/base/arch/fileSystem.cpp:909:43: error: use of undeclared identifier 'POSIX_MADV_WILLNEED'
/mnt/vcpkg-ci/buildtrees/usd/src/v23.05-3a8636d7a3.clean/pxr/base/arch/fileSystem.cpp:910:43: error: use of undeclared identifier 'POSIX_MADV_DONTNEED'
/mnt/vcpkg-ci/buildtrees/usd/src/v23.05-3a8636d7a3.clean/pxr/base/arch/fileSystem.cpp:911:43: error: use of undeclared identifier 'POSIX_MADV_RANDOM'
/mnt/vcpkg-ci/buildtrees/usd/src/v23.05-3a8636d7a3.clean/pxr/base/arch/fileSystem.cpp:914:16: error: use of undeclared identifier 'posix_madvise'

@Adela0814 Adela0814 marked this pull request as draft May 31, 2023 09:18
@ilya-lavrenov
Copy link
Contributor Author

usd is not used by TBB directly.
where is it come from?

@Adela0814
Copy link
Contributor

usd is not used by TBB directly. where is it come from?

usd depends on tbb. You can review error details from https://dev.azure.com/vcpkg/public/_build/results?buildId=90089&view=artifacts&pathAsName=false&type=publishedArtifacts.

@dg0yt
Copy link
Contributor

dg0yt commented Jun 1, 2023

If you think that usd doesn't support android, then you only need to mark it as unsupported on android. It is not a regression.

@ilya-lavrenov
Copy link
Contributor Author

ilya-lavrenov commented Jun 1, 2023

If you think that usd doesn't support android, then you only need to mark it as unsupported on android. It is not a regression.

Right.
Android is not listed as supported https://github.com/PixarAnimationStudios/USD#supported-platforms

@Adela0814
Copy link
Contributor

After fixing the CI error, please convert this PR to Ready for Review, thanks.

@Adela0814 Adela0814 marked this pull request as draft June 2, 2023 08:36
@ilya-lavrenov
Copy link
Contributor Author

ilya-lavrenov commented Jun 2, 2023

After fixing the CI error, please convert this PR to Ready for Review, thanks.

It would be great to have more stable CI:

error: Failed to download from mirror set
error: https://vcpkgassetcacheeastasia.blob.core.windows.net/cache/41b82b829579d81e964212ecb6adf56a02fbe0293c33718c428977eb55df2008ea0af6214e051b5415fdfc828c532276be7b9cfb1523d8fc4dc07d4b337d49e3

I am rerunning CI multiple time and it fails in random places and it became extremely slow since yesterday. Builds are waiting for many hours before being scheduled. What is the reason?
Can you rerun this specific job since I have no right to do it?

@ilya-lavrenov
Copy link
Contributor Author

The issue

error: Failed to download from mirror set
error: https://vcpkgassetcacheeastasia.blob.core.windows.net/cache/41b82b829579d81e964212ecb6adf56a02fbe0293c33718c428977eb55df2008ea0af6214e051b5415fdfc828c532276be7b9cfb1523d8fc4dc07d4b337d49e3?*** SECRET ***: curl failed to download with exit code 22
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

curl: (22) The requested URL returned error: 403 Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.


error: https://download.qt.io/archive/qt/6.5/6.5.1/submodules/qtimageformats-everywhere-src-6.5.1.tar.xz: curl failed to download with exit code 22
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

is not connected with changes in the current PR.

@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Jun 5, 2023
@dan-shaw dan-shaw merged commit cc968d0 into microsoft:master Jun 5, 2023
@ilya-lavrenov ilya-lavrenov deleted the tbb branch June 5, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants