Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libadwaita] update to 1.3.2 #31758

Merged
merged 1 commit into from
Jun 2, 2023
Merged

[libadwaita] update to 1.3.2 #31758

merged 1 commit into from
Jun 2, 2023

Conversation

Cheney-W
Copy link
Contributor

@Cheney-W Cheney-W commented Jun 1, 2023

Fixes #31665

Remove the ${VCPKG_HOST_EXECUTABLE_SUFFIX} from ${GLIB_TOOLS_DIR}/glib-genmarshal with below reasons.

  1. The generated glib-genmarshal file from glib does not have an extension.
  2. Having an extension would cause the following error when install the latest libadwaita:
ninja: error: 'vcpkg/installed/x64-windows/tools/glib/glib-genmarshal.exe', needed by 'src/adw-marshalers.h', missing and no known rule to make it
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Jun 1, 2023
@Cheney-W Cheney-W marked this pull request as ready for review June 2, 2023 02:03
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jun 2, 2023
@dan-shaw dan-shaw merged commit 7920784 into microsoft:master Jun 2, 2023
@Cheney-W Cheney-W deleted the Dev/Cheney/31665 branch June 5, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cheney-W @LilyWangLL @dan-shaw