[imgui] Fix deps of feature allegro5-binding #31871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyWangLL
added
category:port-bug
Cheney-W
approved these changes
Jun 8, 2023
dg0yt
reviewed
Jun 8, 2023
| find_path(ALLEGRO5_INCLUDE_DIRS allegro5/allegro.h) | ||
| target_include_directories(${PROJECT_NAME} PRIVATE ${ALLEGRO5_INCLUDE_DIRS}) | ||
| find_package(unofficial-allegro5 CONFIG REQUIRED) | ||
| target_link_libraries(${PROJECT_NAME} PRIVATE unofficial-allegro5::allegro unofficial-allegro5::allegro_ttf unofficial-allegro5::allegro_font unofficial-allegro5::allegro_main) |
There was a problem hiding this comment.
These target don't use the proper unofficial::allegro5:: namespace.
IIUC no targets were exported by allegro5 until now, so the time to fix allegro5 is now.
There was a problem hiding this comment.
BTW are all these link libraries needed here? unofficial-allegro5::allegro_main doesn't add another main function?
There was a problem hiding this comment.
I think this got merged to master already
There was a problem hiding this comment.
I know, but it is only a few hours, and such mistakes have been fixed in the past.
It really sucks if there is neither enough time for review, nor enough quality.
ybogo
pushed a commit
to ybogo/vcpkg
that referenced
this pull request
Jun 9, 2023
* [imgui] Fix feature allegro5-binding deps * update version * Update imgui.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17058
allegro5targets.allegro5ofimgui[allegro5-binding].Usage test pass on
x64-linux.The test codes from #17125 (comment) passed on
x64-linux.SHA512s are updated for each updated downloadThe "supports" clause reflects platforms that may be fixed by this new versionAny fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.