Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdl-sdk] Workaround broken gcc-11 <bit> #32008

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

BillyONeal
Copy link
Member

No description provided.

@BillyONeal BillyONeal added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jun 14, 2023
@@ -65,6 +65,25 @@ endif()

# MDL-SDK

# The patch "workaround gcc bit" works around <bit> included with gcc included with Ubuntu 22.04
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can skip this line and just tell people to use blame...

@jimwang118
Copy link
Contributor

I am also testing locally, the environment is as follows:

Ubuntu 22.10
gcc 12.2.0

The error is as follows:

/usr/include/c++/12/bit:334:17: error: ‘__is_constant_evaluated’ is not a member of ‘mi::base::std’; did you mean ‘std::__is_constant_evaluated’?
  334 |       if (!std::__is_constant_evaluated())
      |                 ^~~~~~~~~~~~~~~~~~~~~~~

install-x64-linux-dbg-out.log

@jimwang118 jimwang118 marked this pull request as draft June 15, 2023 08:39
@BillyONeal
Copy link
Member Author

I am also testing locally, the environment is as follows:

Ubuntu 22.10
gcc 12.2.0

I'm not trying to make 22.10 work at this time, only what we are trying to update the fleet to, 22.04.

@BillyONeal BillyONeal marked this pull request as ready for review June 15, 2023 17:39
@BillyONeal BillyONeal merged commit 1f47615 into microsoft:master Jun 15, 2023
@BillyONeal BillyONeal deleted the mdl-sdk branch June 15, 2023 23:50
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants