Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openblas] Support arm64-uwp builds #32067

Merged
merged 5 commits into from
Jun 22, 2023
Merged

[openblas] Support arm64-uwp builds #32067

merged 5 commits into from
Jun 22, 2023

Conversation

daniel-ju
Copy link
Contributor

Fixes #32066.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@daniel-ju daniel-ju marked this pull request as ready for review June 17, 2023 06:32
@Cheney-W Cheney-W added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. labels Jun 19, 2023
Cheney-W
Cheney-W previously approved these changes Jun 19, 2023
View reviewed changes
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jun 19, 2023
@daniel-ju
Copy link
Contributor Author

Can this be merged? Thanks!

BillyONeal
BillyONeal reviewed Jun 21, 2023
View reviewed changes
ports/openblas/vcpkg.json Outdated Show resolved Hide resolved
ports/openblas/portfile.cmake Outdated Show resolved Hide resolved
@BillyONeal
Copy link
Member

Proposal: https://github.com/BillyONeal/vcpkg/commits/openblas-proposal

@daniel-ju
Copy link
Contributor Author

Thanks @BillyONeal for the review and improvements here!

@vicroms vicroms merged commit 6f979a9 into microsoft:master Jun 22, 2023
@daniel-ju daniel-ju deleted the openblas-arm64-uwp branch August 9, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@Cheney-W Cheney-W Cheney-W left review comments

Assignees

@Cheney-W Cheney-W

Labels
category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[openblas] Support arm64-uwp builds
4 participants
@daniel-ju @BillyONeal @Cheney-W @vicroms