Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sqlite3] Fix option passing #32404

Merged
merged 2 commits into from
Jul 11, 2023
Merged

[sqlite3] Fix option passing #32404

merged 2 commits into from
Jul 11, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jul 5, 2023 •
edited
Loading

Fixes another regression from #29376, reported in #32398.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Jul 5, 2023
@JonLiu1993
Copy link
Member

JonLiu1993 commented Jul 10, 2023 •
edited
Loading

All features are tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static
  • x64-linux

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jul 10, 2023
@BillyONeal BillyONeal merged commit be82dd7 into microsoft:master Jul 11, 2023
@BillyONeal
Copy link
Member

Thank you!

@dg0yt dg0yt deleted the sqlite3 branch July 11, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dg0yt @JonLiu1993 @BillyONeal @MonicaLiu0311