Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[async-mqtt] tls dependencies #32551

Merged
merged 8 commits into from
Jul 24, 2023
Merged

[async-mqtt] tls dependencies #32551

merged 8 commits into from
Jul 24, 2023

Conversation

omarhogni
Copy link
Contributor

@MonicaLiu0311 MonicaLiu0311 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jul 13, 2023
@omarhogni omarhogni changed the title Async mqtt tls [async-mqtt] tls dependencies Jul 13, 2023
@omarhogni omarhogni marked this pull request as ready for review July 13, 2023 10:05
@LilyWangLL LilyWangLL added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Jul 14, 2023
@LilyWangLL
Copy link
Contributor

All features passed with following triplets:

x86-windows
x64-windows
x64-windows-static

LilyWangLL
LilyWangLL previously approved these changes Jul 14, 2023
View reviewed changes
@LilyWangLL LilyWangLL added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Jul 14, 2023
BillyONeal
BillyONeal requested changes Jul 14, 2023
View reviewed changes
ports/async-mqtt/portfile.cmake Outdated Show resolved Hide resolved
ports/async-mqtt/portfile.cmake Outdated Show resolved Hide resolved
@BillyONeal BillyONeal removed the info:reviewed Pull Request changes follow basic guidelines label Jul 14, 2023
@BillyONeal BillyONeal marked this pull request as draft July 14, 2023 23:56
@redboltz redboltz mentioned this pull request Jul 15, 2023
Closed
@omarhogni omarhogni marked this pull request as ready for review July 21, 2023 12:02
BillyONeal
BillyONeal previously approved these changes Jul 21, 2023
View reviewed changes
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jul 24, 2023
LilyWangLL
LilyWangLL previously approved these changes Jul 24, 2023
View reviewed changes
dg0yt
dg0yt reviewed Jul 24, 2023
View reviewed changes
ports/async-mqtt/vcpkg.json Outdated Show resolved Hide resolved
@BillyONeal BillyONeal dismissed stale reviews from LilyWangLL and themself via 8ed3a21 July 24, 2023 18:31
@BillyONeal
Copy link
Member

Thanks for the fix! I fixed @dg0yt's nitpick and clarified by using vcpkg_check_features. I'll merge as soon as build comes back.

@BillyONeal BillyONeal merged commit 57ca276 into microsoft:master Jul 24, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@BillyONeal BillyONeal BillyONeal approved these changes

@LilyWangLL LilyWangLL LilyWangLL left review comments

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OpenSSL] Missing dependency in vcpkg port
5 participants
@omarhogni @LilyWangLL @BillyONeal @dg0yt @MonicaLiu0311