Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vxl] first port - vxl commit 7a130cf of 2018/04/14 #3265

Merged
merged 2 commits into from
Apr 17, 2018

Conversation

pgrison
Copy link
Contributor

@pgrison pgrison commented Apr 17, 2018

I added a port for vxl ( https://github.com/vxl/vxl )
Just one slight issue: since all headers are into vxl's sub-headers (vgl/, core/ v3p/), the auto-include feature of vcpkg doesn't work optimally.
Perhaps some vcpkg commands must be added in the port file to fix that.
(pgrison@3dce326)

@ras0219-msft
Copy link
Contributor

Looks great, thanks for the PR!

What do you mean that the auto-include feature doesn't work optimally? Does vxl expect you to #include <vcl/vcl_algorithm.h> while their cmake build installs the files to vxl/vcl/vcl_algorithm.h?

@ras0219-msft ras0219-msft merged commit fbf5fe8 into microsoft:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants