Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend self-contain repos/submodules regardless of build system. #32698

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Recommend self-contain repos/submodules regardless of build system. #32698

merged 1 commit into from
Aug 3, 2023

Conversation

davidmatson
Copy link
Contributor

Fixes #31466.

@davidmatson
Copy link
Contributor Author

@dan-shaw - this is just updating the recommendation text; it still fixes the associated issue but doesn't touch the instructions for VS.

@BillyONeal
Copy link
Member

I think the medium term outcome will be most of this stuff moves to the learn site.

@JonLiu1993 JonLiu1993 added the category:documentation To resolve the issue, documentation will need to be updated label Jul 24, 2023
@JonLiu1993 JonLiu1993 requested review from vicroms and AugP July 28, 2023 06:08
@vicroms vicroms added the info:reviewed Pull Request changes follow basic guidelines label Aug 3, 2023
@JavierMatosD JavierMatosD merged commit 491d019 into microsoft:master Aug 3, 2023
@UnixY2K UnixY2K mentioned this pull request Aug 17, 2023
Merged
dan-shaw pushed a commit that referenced this pull request Aug 24, 2023
@UnixY2K
[vcpkg docs][ES] Sync with English readme (#32698) (#33230)
b4d94ec 
* Update README_es.md

sync with the latest changes of the main readme file (#32698)

* fix translation
@davidmatson davidmatson deleted the submoduleReadme branch September 6, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicroms vicroms vicroms approved these changes

@AugP AugP Awaiting requested review from AugP

Assignees

@vicroms vicroms

@AugP AugP

@JonLiu1993 JonLiu1993

Labels
category:documentation To resolve the issue, documentation will need to be updated info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update doc guidance for MSBuild to get vcpkg via submodule
6 participants
@davidmatson @BillyONeal @vicroms @AugP @JavierMatosD @JonLiu1993