-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libxdf] Add new port #32816
[libxdf] Add new port #32816
Conversation
@myd7349, Thanks for your PR, if this PR is ready for review please let me know. |
When I tested the usage, I get this error; CMakeLists.txt
usageTest.cpp
Config:
Build
|
I found that the upstream find_package (pugixml 1.9 QUIET) has obvious version requirements for the pugixml port. I added find_package (pugixml CONFIG REQUIRED) to the CMakeLists to successfully find pugixml.lib |
Hi! @JonLiu1993 Thanks for your review. I have created a PR to address this issue: xdf-modules/libxdf#38. |
Tested usage successfully by
|
ports/libxdf/vcpkg.json
Outdated
@@ -0,0 +1,18 @@ | |||
{ | |||
"name": "libxdf", | |||
"version-date": "2023-08-02", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the upstream version is 0.99.8.
"version-date": "2023-08-02", | |
"version": "0.99.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! @JavierMatosD There was a bug in 0.99.8
and have been fixed by xdf-modules/libxdf#38. That why I upgrade
from 0.99.8
to latest commit. Without this fix, a 60~ LOC patch file is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a stable release is preferred, then I can revert the last two commits of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! We can drop the patch when we update the port next :)
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.