Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Fix the broken link in README_xx.md #32923

Merged
merged 10 commits into from
Aug 4, 2023
Merged

[Docs] Fix the broken link in README_xx.md #32923

merged 10 commits into from
Aug 4, 2023

Conversation

Cheney-W
Copy link
Contributor

@Cheney-W Cheney-W commented Aug 3, 2023

Fixes #32883

  1. Fix the broken link in README_xx.md.
  2. Fix the table of contents jump issue in README_zh_CN.md.
  3. Update the content in README_zh_CN.md.

@Cheney-W Cheney-W added category:documentation To resolve the issue, documentation will need to be updated info:internal This PR or Issue was filed by the vcpkg team. labels Aug 3, 2023
NaokiM03
NaokiM03 reviewed Aug 4, 2023
View reviewed changes
README_ko_KR.md Outdated Show resolved Hide resolved
@NaokiM03
Copy link

NaokiM03 commented Aug 4, 2023

It may be necessary to replace docs/users/assetcaching.md with https://learn.microsoft.com/vcpkg/users/assetcaching.

P.S.
This is not present in README_zh_CN.md and README_fr.md.

@Cheney-W Cheney-W marked this pull request as ready for review August 4, 2023 02:55
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Aug 4, 2023
@JavierMatosD JavierMatosD merged commit 78b6158 into microsoft:master Aug 4, 2023
15 checks passed
@Cheney-W Cheney-W deleted the Dev/Cheney/doc branch August 7, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaokiM03 NaokiM03 NaokiM03 left review comments

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:documentation To resolve the issue, documentation will need to be updated info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document links are broken in README_xx.md
4 participants
@Cheney-W @NaokiM03 @LilyWangLL @JavierMatosD