[Thorvg] Update Thorvg port to v0.10.0 #32934
Conversation
JonLiu1993
changed the title
JonLiu1993
added
the
category:port-update
ports/thorvg/vcpkg.json
Outdated
| "description": "ThorVG is a platform-independent portable library for drawing vector-based scenes and animations", | ||
| "homepage": "https://www.thorvg.org", | ||
| "license": "MIT", | ||
| "supports": "!(arm & uwp)", | ||
| "supports": "!(arm & uwp) & !windows", |
There was a problem hiding this comment.
@rinechran, thanks for the PR, could you explain why the new version doesn't support the windows platform?
There was a problem hiding this comment.
There is an error in the current Windows build.
For this, I am planning to solve the problem and update it by pring it directly to Thorvg.
There was a problem hiding this comment.
Ports that do not support certain triples in vcpkg for the time being can write them to the baseline, please add
thorvg:x86-windows=fail
thorvg:x64-windows=fail
thorvg:x64-windows-static=fail
thorvg:x64-windows-static-md=fail
under this:
Line 1306 in 1e9cf69
There was a problem hiding this comment.
And if this port doesn't support some triplets, please add supports keyword in vcpkg.json instead of modify baseline.
There was a problem hiding this comment.
Sorry, I found the cause and I'm going to patch it up now and upload it again
I made a mistake in the review
|
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
|
Feature |
./vcpkg x-add-version --alland committing the result.