[openmvs] add arm support #33101
[openmvs] add arm support #33101
Conversation
ports/openmvs/fix-arm.patch
Outdated
| -SET(OpenMVS_USE_SSE ON CACHE BOOL "Enable SSE optimizations") | ||
| +cmake_policy(SET CMP0127 NEW) | ||
| +cmake_dependent_option(OpenMVS_USE_SSE "Enable SSE optimizations" ON "NOT CMAKE_SYSTEM_PROCESSOR MATCHES \"^(arm|ARM|aarch64|AARCH64).\"" OFF) |
There was a problem hiding this comment.
This patches out what is aleady an option?
There was a problem hiding this comment.
From upstream: cdcseacave/openMVS#1042
There was a problem hiding this comment.
There was a problem hiding this comment.
What should we do with this PR next? Are we waiting for the upstream to apply the dg0yt's suggestion?
There was a problem hiding this comment.
@Cheney-W You are the reviewer. It is up to you give guidance whether to avoid the patch because it can be avoided, or to simply accept the patch for being accepted upstream.
There was a problem hiding this comment.
Yeah the alternative is to check the VCPKG_TARGET_ARCHITECTURE and set OpenMVS_USE_SSE accordingly. The result is the same.
There was a problem hiding this comment.
@autoantwort Could you please apply this modification to this PR?
Cheney-W
added
the
category:port-bug
autoantwort
force-pushed
the
openmvs-fix.arm
branch
from
fc4e69f
to
f60e4bb
Compare
Currently it fails because SSE is also enables on the arm platform