Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libxml2] Update to 2.11.5 #33461

Merged
merged 5 commits into from
Sep 6, 2023
Merged

[libxml2] Update to 2.11.5 #33461

merged 5 commits into from
Sep 6, 2023

Conversation

SvenPStarFinanz
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Adela0814 Adela0814 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 31, 2023
Adela0814
Adela0814 suggested changes Aug 31, 2023
View reviewed changes
ports/libxml2/disable-docs.patch Outdated Show resolved Hide resolved
ports/libxml2/portfile.cmake Outdated Show resolved Hide resolved
@Adela0814
Copy link
Contributor

Please fix the CI error:
error message(D:\buildtrees\ffmpeg\build-x64-windows-static-rel-out.log):

=== CONFIGURING ===
ERROR: libxml-2.0 not found using pkg-config

Please find details from https://dev.azure.com/vcpkg/public/_build/results?buildId=93532&view=artifacts&pathAsName=false&type=publishedArtifacts.

@Adela0814
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@Adela0814 Adela0814 marked this pull request as draft August 31, 2023 05:59
dg0yt
dg0yt reviewed Sep 3, 2023
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICS fix_cmakelist.patch doesn't need to be modified at all.

@SvenPStarFinanz SvenPStarFinanz marked this pull request as ready for review September 5, 2023 05:53
@Adela0814
Copy link
Contributor

All feature tested pass in the following triplets:

  • x64-windows
  • x86-windows
  • x64-windows-static

Usage tested pass on x64-windows.

@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Sep 5, 2023
@BillyONeal BillyONeal merged commit 52678a2 into microsoft:master Sep 6, 2023
15 checks passed
@BillyONeal
Copy link
Member

Thanks for the update!

@SvenPStarFinanz SvenPStarFinanz deleted the libxml2_2.11.5 branch September 7, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@Adela0814 Adela0814 Adela0814 approved these changes

Assignees

@Adela0814 Adela0814

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SvenPStarFinanz @Adela0814 @BillyONeal @dg0yt