Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-sdk-cpp] Fix and improve the manifest generation script. #33704

Merged
merged 4 commits into from
Sep 13, 2023
Merged

[aws-sdk-cpp] Fix and improve the manifest generation script. #33704

merged 4 commits into from
Sep 13, 2023

Conversation

teo-tsirpanis
Copy link
Contributor

This PR updates the manifest generation script of the aws-sdk-cpp so that it:

  • Understands the new repository layout of the AWS SDK for C++. After rerunning it, 86 new SDKs were added.
  • Understands that some SDKs depend on each other, adding them as feature dependencies.
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@teo-tsirpanis
Bring back vcpkg.in.json and update it.
4ec5c95
@teo-tsirpanis
Update generateFeatures.ps1.
c0f0c12 
It now works with the new repository structure and parses and encodes the dependencies a feature might have.
@teo-tsirpanis
Regenerate the manifest.
cd0dd50
@teo-tsirpanis
Update version database.
b8e3f57
@LilyWangLL LilyWangLL added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Sep 12, 2023
@LilyWangLL
Copy link
Contributor

All features passed with following triplets:

x86-windows
x64-windows
x64-windows-static

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Sep 13, 2023
@BillyONeal BillyONeal merged commit b6aef4b into microsoft:master Sep 13, 2023
15 checks passed
@BillyONeal
Copy link
Member

Thanks for making the script more robust!

@teo-tsirpanis teo-tsirpanis deleted the aws-sdk-cpp-feature-dependencies branch September 14, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teo-tsirpanis @LilyWangLL @BillyONeal