Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upb] tools no uwp #33864

Merged
merged 5 commits into from
Sep 20, 2023
Merged

[upb] tools no uwp #33864

merged 5 commits into from
Sep 20, 2023

Conversation

FrankXie05
Copy link
Contributor

@FrankXie05 FrankXie05 commented Sep 19, 2023

Fix #33775

Note:
protoc does not support uwp.

Same error and explanation:
#33622 (comment)

protoc-gen-upbdefs.cc.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl google::protobuf::compiler::CodeGenerator::CodeGenerator(void)" (__imp_??0CodeGenerator@compiler@protobuf@google@@QEAA@XZ) referenced in function "public: __cdecl upbc::`anonymous namespace'::Generator::Generator(void)" (??0Generator@?A0x1ec6339d@upbc@@QEAA@XZ)
protoc-gen-upbdefs.cc.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: virtual __cdecl google::protobuf::compiler::CodeGenerator::~CodeGenerator(void)" (__imp_??1CodeGenerator@compiler@protobuf@google@@UEAA@XZ) referenced in function "private: virtual __cdecl upbc::`anonymous namespace'::Generator::~Generator(void)" (??1Generator@?A0x1ec6339d@upbc@@EEAA@XZ)
protoc-gen-upbdefs.cc.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) void __cdecl google::protobuf::compiler::ParseGeneratorParameter(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::vector<struct std::pair<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > >,class std::allocator<struct std::pair<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > > > *)" (__imp_?ParseGeneratorParameter@compiler@protobuf@google@@YAXAEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@PEAV?$vector@U?$pair@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V12@@std@@V?$allocator@U?$pair@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V12@@std@@@2@@5@@Z) referenced in function "private: virtual bool __cdecl upbc::`anonymous namespace'::Generator::Generate(class google::protobuf::FileDescriptor const *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class google::protobuf::compiler::GeneratorContext *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > *)const " (?Generate@Generator@?A0x1ec6339d@upbc@@EEBA_NPEBVFileDescriptor@protobuf@google@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@PEAVGeneratorContext@compiler@56@PEAV78@@Z)
protoc-gen-upbdefs.cc.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) int __cdecl google::protobuf::compiler::PluginMain(int,char * * const,class google::protobuf::compiler::CodeGenerator const *)" (__imp_?PluginMain@compiler@protobuf@google@@YAHHQEAPEADPEBVCodeGenerator@123@@Z) referenced in function main
protoc-gen-upbdefs.cc.obj : error LNK2001: unresolved external symbol "public: virtual bool __cdecl google::protobuf::compiler::CodeGenerator::HasGenerateAll(void)const " (?HasGenerateAll@CodeGenerator@compiler@protobuf@google@@UEBA_NXZ)
protoc-gen-upbdefs.cc.obj : error LNK2001: unresolved external symbol "public: virtual bool __cdecl google::protobuf::compiler::CodeGenerator::GenerateAll(class std::vector<class google::protobuf::FileDescriptor const *,class std::allocator<class google::protobuf::FileDescriptor const *> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class google::protobuf::compiler::GeneratorContext *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > *)const " (?GenerateAll@CodeGenerator@compiler@protobuf@google@@UEBA_NAEBV?$vector@PEBVFileDescriptor@protobuf@google@@V?$allocator@PEBVFileDescriptor@protobuf@google@@@std@@@std@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@6@PEAVGeneratorContext@234@PEAV76@@Z)
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@FrankXie05 FrankXie05 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Sep 19, 2023
@FrankXie05 FrankXie05 marked this pull request as ready for review September 20, 2023 02:10
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Sep 20, 2023
@vicroms vicroms merged commit 39f2aee into microsoft:master Sep 20, 2023
15 checks passed
@FrankXie05 FrankXie05 deleted the 33775 branch September 21, 2023 02:14
autoantwort pushed a commit to autoantwort/vcpkg that referenced this pull request Sep 21, 2023
* [upb] tools no uwp

* format

* version

* revert patch

* version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[upb] Build failure
3 participants