[dirent] update to 1.24

[jiayuehua]

• Changes comply with the maintainer guide
• SHA512s are updated for each updated download
• The "supports" clause reflects platforms that may be fixed by this new version
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

[FrankXie05]

@jiayuehua So, do you plan to do all simple port updates?

[jiayuehua]

no ,I will soon stop.

[jiayuehua]

WIN32 marco to hard to fix

[dg0yt]

This patch only changes WIN32 macros C files. This is normally passed at the command line. Why do we need another patch?

[jiayuehua]

I have made the patch much smaller. Mainly is fix macro #if S_IFLNK != 0, because libmagic think WIN32 always IS_IFLNK==0, but after libdirent update S_IFLNK is also not zero.

[dg0yt]

What I can see from CI logs:
filemagic sets WIN32 during Windows builds, so it doesn't need to be patched out.
But there seems to be a problem with port getopt-win32 because it installs a header which is also provided in-source of many packages as part of the gnulib (gl, not glib) cross platform polyfill:

Importing getopt library
D:\buildtrees\libmagic\src\FILE5_40-612ec1dc40.clean\src\file.c(63): warning C4273: 'getopt_long_a': inconsistent dll linkage
D:\installed\x64-windows\include\getopt.h(100): note: see previous definition of 'getopt_long_a'
...

[jiayuehua]

What I can see from CI logs: filemagic sets WIN32 during Windows builds, so it doesn't need to be patched out. But there seems to be a problem with port getopt-win32 because it installs a header which is also provided in-source of many packages as part of the gnulib (gl, not glib) cross platform polyfill:

Importing getopt library
D:\buildtrees\libmagic\src\FILE5_40-612ec1dc40.clean\src\file.c(63): warning C4273: 'getopt_long_a': inconsistent dll linkage
D:\installed\x64-windows\include\getopt.h(100): note: see previous definition of 'getopt_long_a'
...

Do you mean port getopt-win32 should not define getopt_long_a to privent linkage issue?

[dg0yt]

Do you mean port getopt-win32 should not define getopt_long_a to privent linkage issue?

getopt-win32 may cause installation order problems. But it is a baseline issue, not related to this PR.

[jiayuehua]

@FrankXie05 could you please take a look to this pr?