Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openimageio] Point to a new repo and fix checksums #34231

Merged
merged 2 commits into from
Oct 4, 2023
Merged

[openimageio] Point to a new repo and fix checksums #34231

merged 2 commits into from
Oct 4, 2023

Conversation

SlawekNowy
Copy link
Contributor

Fixes #34173

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

BillyONeal
BillyONeal requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a statement somewhere on upstream's website that proves that AcademySoftwareFoundation/OpenImageIO is indeed the correct target rather than this being something like their org account being temporarily compromised.

Thanks for the PR, let's see what upstream does!

@BillyONeal BillyONeal added the depends:upstream-changes Waiting on a change to the upstream project label Oct 4, 2023
@BillyONeal BillyONeal marked this pull request as draft October 4, 2023 00:38
@BillyONeal BillyONeal removed the depends:upstream-changes Waiting on a change to the upstream project label Oct 4, 2023
@BillyONeal BillyONeal marked this pull request as ready for review October 4, 2023 21:33
BillyONeal
BillyONeal approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream made the statement. Thanks for the fix!

@BillyONeal BillyONeal merged commit accd798 into microsoft:master Oct 4, 2023
15 checks passed
@dg0yt dg0yt mentioned this pull request Oct 9, 2023
Closed
clementperon pushed a commit to clementperon/vcpkg that referenced this pull request Oct 16, 2023
@SlawekNowy @clementperon
[openimageio] Point to a new repo and fix checksums (microsoft#34231)
3b23320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[openimageio] Build error: File does not have the expected hash
2 participants
@SlawekNowy @BillyONeal