[azure-core-cpp] Fix gcc13 compilation error

[jimwang118]

Fixes #34272
/vcpkg/buildtrees/azure-core-cpp/src/ore_1.10.2-d563a045e8.clean/_/_/_/inc/azure/core/base64.hpp:42:55: error: ‘uint8_t’ was not declared in this scope
Add stdint.h header file, fixed via PR 5031 upstream.

• Changes comply with the maintainer guide
• SHA512s are updated for each updated download
• The "supports" clause reflects platforms that may be fixed by this new version
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

Usage test pass with following triplets:

x64-linux

[BillyONeal]

@LarryOsterman FYI

[LarryOsterman]

Due to the way that the Azure SDK for C++ publishes its packages, all changes made to the vcpkg repository will be discarded when the Azure SDK for C++ is next released. As such, making changes to fix issues in the vcpkg repository are always ephemeral and should probably be avoided.

The Azure SDK is located at https://github.com/Azure/azure-sdk-for-cpp and we welcome community contributions like this one.

FWIW, we currently have an outstanding issue regarding this specific change: Azure/azure-sdk-for-cpp#5007.

[jimwang118]

Due to the way that the Azure SDK for C++ publishes its packages, all changes made to the vcpkg repository will be discarded when the Azure SDK for C++ is next released. As such, making changes to fix issues in the vcpkg repository are always ephemeral and should probably be avoided.

The Azure SDK is located at https://github.com/Azure/azure-sdk-for-cpp and we welcome community contributions like this one.

FWIW, we currently have an outstanding issue regarding this specific change: Azure/azure-sdk-for-cpp#5007.

Okay, then I will mark this PR as draft, wait for you to fix it, and then update it.

[LarryOsterman]

Due to the way that the Azure SDK for C++ publishes its packages, all changes made to the vcpkg repository will be discarded when the Azure SDK for C++ is next released. As such, making changes to fix issues in the vcpkg repository are always ephemeral and should probably be avoided.
The Azure SDK is located at https://github.com/Azure/azure-sdk-for-cpp and we welcome community contributions like this one.
FWIW, we currently have an outstanding issue regarding this specific change: Azure/azure-sdk-for-cpp#5007.

Okay, then I will mark this PR as draft, wait for you to fix it, and then update it.

So I took a look at the issue. The base64.hpp file already includes cstdint which is supposed to include stdint.h.

The version of cstdint on my machine (in /usr/include/x86_64-linux-gnu/c++/11) does include stdint.h. Are you using a different C++ runtime library?

EDIT: I think I figured it out. cstdint only defines the std::uint8_t type (and friends), stdint.h defines the uint8_t types in the global namespace. most of the time, cstdint also includes stdint.h, but It appears that the version of the runtime library that you are using does not (possibly because of C++ module support). I've added the header to the source code (and updated our CI pipelines to add clang-13 and clang-15: Azure/azure-sdk-for-cpp#5031.

[BillyONeal]

EDIT: I think I figured it out. cstdint only defines the std::uint8_t type (and friends), stdint.h defines the uint8_t types in the global namespace.

Right, <cfoo> means "use std::foo", <foo.h> means "use ::foo".

[LarryOsterman]

EDIT: I think I figured it out. cstdint only defines the std::uint8_t type (and friends), stdint.h defines the uint8_t types in the global namespace.

Right, <cfoo> means "use std::foo", <foo.h> means "use ::foo".

What complicates this is that many (most?) implementations of cstdint include stdint.h (including the version of the CRT used in our CI pipelines). The version of cstdint that the reporters are using do not. That is why even after selecting clang-13 (and clang-15) we didn't see a problem.

[data-queue]

Can you fix merge conflicts? And I think we can use the upstream patch since it merged

[jimwang118]

Can you fix merge conflicts? And I think we can use the upstream patch since it merged

OK, I'll resolve the merge conflict and fix it with the upstream patch.