[icu] Fix osx release only builds #34539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg0yt
reviewed
Oct 17, 2023
ports/icu/portfile.cmake
Outdated
Comment on lines
37
to
39
| if (NOT DEFINED VCPKG_BUILD_TYPE OR VCPKG_BUILD_TYPE STREQUAL "debug") | ||
| set(DEBUG_TRIPLET ${TARGET_TRIPLET}-dbg) | ||
| endif() |
There was a problem hiding this comment.
Setting the variable as before doesn't really break anything, does it?
There was a problem hiding this comment.
If the variable is set, we will loop over it here and try to fixup rpath on an inexistent file. It's not very self explanatory ... We'd probably better have one list to loop over than two separate variables.
jimwang118
added
the
category:port-bug
m-kuhn
force-pushed
the
icu_osx_dynamic_release
branch
from
5edffc9
to
7b752fd
Compare
|
Compile test pass with following triplets: |
|
I think I'm missing some context. Can you explain what these changes do? |
data-queue
added
info:reviewed
|
If we only build |
fwcd
pushed a commit
to fwcd/vcpkg
that referenced
this pull request
Mar 21, 2024
* [icu] Fix osx release only builds * Use list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't necessarily build "debug", in case it's not built, avoid looping over this config in https://github.com/microsoft/vcpkg/pull/34539/files#diff-ea2b03d0dcb43b39cfac7b4f96e0ba52a5e4f15c1df6986850e0d52d56229430R94