[openvino] support dynamic protobuf #34651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-lavrenov
force-pushed
the
openvino-2023.1.0
branch
2 times, most recently
from
0402b89
to
ae17d2f
Compare
Adela0814
added
the
category:port-feature
Adela0814
reviewed
Oct 23, 2023
| @@ -15,6 +15,7 @@ | |||
| "homepage": "https://github.com/openvinotoolkit/openvino", | |||
| "documentation": "https://docs.openvino.ai/latest/index.html", | |||
| "license": "Apache-2.0", | |||
| "supports": "!uwp", | |||
There was a problem hiding this comment.
Can you explain why UWP is not supported? I'm not able to find any relevant instructions.
There was a problem hiding this comment.
because OpenVINO uses LoadLibrary, which is prohibited in UWP Apps
https://github.com/openvinotoolkit/openvino/blob/b67cff7cd5bcf44cc0a24e041f1097aa4636a4d3/src/common/util/src/os/win/win_shared_object_loader.cpp#L60-L62
It was detected through the integration with OpenCV where UWP is mandatory - we have compilation issues with OpenVINO. So, it's better to declare absence of UWP support until it's investigated by OpenVINO development team.
Adela0814
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported several patches from upstream:
Note, that all patches except one will be removed during update to next OpenVINO release.
Currently, they are required for integration with OpenCV (PR #33883)