[libmysql] Update to 8.0.34 #34736
Merged
[libmysql] Update to 8.0.34 #34736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimwang118
added
the
category:port-update
11 tasks
silverqx
reviewed
Oct 27, 2023
There was a problem hiding this comment.
I tried this dg0yt/libmysql branch and I'm getting this warning about empty folder:
-- Installing: O:/Code/c_libs/vcpkg-tinyorm-port-qt6/packages/libmysql_x64-windows/share/libmysql/vcpkg-cmake-wrapper.cmake
-- Installing: O:/Code/c_libs/vcpkg-tinyorm-port-qt6/packages/libmysql_x64-windows/share/libmysql/usage
-- Performing post-build validation
warning: There should be no empty directories in O:\Code\c_libs\vcpkg-tinyorm-port-qt6\packages\libmysql_x64-windows. The following empty directories were found:
O:\Code\c_libs\vcpkg-tinyorm-port-qt6\packages\libmysql_x64-windows\lib\debug
warning: If a directory should be populated but is not, this might indicate an error in the portfile.
If the directories are not needed and their creation cannot be disabled, use something like this in the portfile to remove them:
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/lib/debug")
error: Found 1 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile: O:\Code\c_libs\vcpkg-tinyorm-port-qt6\ports\libmysql\portfile.cmake
Elapsed time to handle libmysql:x64-windows: 3.2 min
Total install time: 3.2 min
The package libmysql provides CMake targets:
find_package(libmysql REQUIRED)
target_link_libraries(main PRIVATE ${MYSQL_LIBRARIES})
Downstream Find modules are not standardized and cannot be wrapped reliably. By moving the legacy wrapper behaviour to a config module, we can catch those users which were relying on the old usage, and display the instructions for migrating to the canonical unofficial usage.
dg0yt
commented
Oct 29, 2023
| MESSAGE(STATUS "BSD built in DNS SRV APIs") | ||
| ELSE() | ||
| FIND_LIBRARY(RESOLV_LIBRARY NAMES resolv) | ||
| + FIND_LIBRARY(RESOLV_LIBRARY NAMES resolv PATHS ${CMAKE_C_IMPLICIT_LINK_DIRECTORIES} NO_DEFAULT_PATH) |
There was a problem hiding this comment.
Explicit search in CMAKE_C_IMPLICIT_LINK_DIRECTORIES only if regular search fails.
|
Usage test pass with following triplets: |
|
It's ready? Can I try it with my port? |
Merged
7 tasks
|
@silverqx It was ready, it was merged and so it is readily available in master. |
|
I tried it now with x64-windows-static and x64-windows triplets and works without errors 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to 8.0.34.
Ensure devendoring of dependencies (as possible), in particular zstd, cf. #34640 (comment).
Fix pkg-config file installation.
Migrate to canonical unofficial CMake Config package (with polyfill for most transition cases). Same target name regardless of library linkage.
Limited support for cross builds, tested with arm64-linux (local) and arm64-windows (vcpkg CI).
Cleanup.