Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lensfun] Add new port #34783

Merged
merged 16 commits into from
Oct 31, 2023
Merged

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Oct 30, 2023

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
    - [ ] The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@JonLiu1993 JonLiu1993 requested review from jimwang118 and removed request for jimwang118 October 30, 2023 03:01
@JackBoosY JackBoosY marked this pull request as ready for review October 30, 2023 04:13
@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 30, 2023
ports/lensfun/portfile.cmake Outdated Show resolved Hide resolved
@LilyWangLL
Copy link
Contributor

lensfun[sse2,tool]:x64-windows build failed with the following error:

F:\lens\buildtrees\lensfun\src\v0.3.4-2231d3b854.clean\apps\lenstool\rgbpixel.h(54): note: see declaration of 'RGBpixel'
F:\lens\buildtrees\lensfun\src\v0.3.4-2231d3b854.clean\apps\lenstool\image.cpp(17): warning C4244: 'return': conversion from 'double' to 'float', possible loss of data
F:\lens\buildtrees\lensfun\src\v0.3.4-2231d3b854.clean\apps\lenstool\image.cpp(22): warning C4244: 'return': conversion from 'double' to 'float', possible loss of data
F:\lens\buildtrees\lensfun\src\v0.3.4-2231d3b854.clean\apps\lenstool\image.cpp(42): warning C4273: 'lanczos_func': inconsistent dll linkage
F:\lens\buildtrees\lensfun\src\v0.3.4-2231d3b854.clean\apps\lenstool\image.h(45): note: see previous definition of 'private: static float * Image::lanczos_func'
F:\lens\buildtrees\lensfun\src\v0.3.4-2231d3b854.clean\apps\lenstool\image.cpp(42): error C2491: 'Image::lanczos_func': definition of dllimport static data member not allowed

@LilyWangLL LilyWangLL added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Oct 30, 2023
@LilyWangLL LilyWangLL marked this pull request as draft October 30, 2023 09:27
@JackBoosY
Copy link
Contributor Author

Remove feature tool since it always need dynamic build and have issues in OSX.

@JackBoosY JackBoosY marked this pull request as ready for review October 31, 2023 07:20
@LilyWangLL
Copy link
Contributor

All features passed with following triplets:

x86-windows
x64-windows
x64-windows-static

@LilyWangLL LilyWangLL added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Oct 31, 2023
@JavierMatosD JavierMatosD merged commit edd68d8 into microsoft:master Oct 31, 2023
15 checks passed
Comment on lines +19 to +26
"features": {
"sse": {
"description": "Build with support for SSE"
},
"sse2": {
"description": "Build with support for SSE2"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackBoosY Please remove these features. Arch settings are not features and SSE2 should be support on everything !arm.

@JackBoosY JackBoosY deleted the jack/add_-lensfun branch November 1, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants