Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[poco] Update to 1.12.5p1 #35307

Merged
merged 1 commit into from
Nov 29, 2023
Merged

[poco] Update to 1.12.5p1 #35307

merged 1 commit into from
Nov 29, 2023

Conversation

mltucker
Copy link
Contributor

@mltucker mltucker commented Nov 24, 2023 •
edited
Loading

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@mltucker
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Comrex AG"

@mltucker
Copy link
Contributor Author

@Cheney-W could you help get this updated? 1.12.5 had a critical bug which was fixed in 1.12.5p1. I’m not sure if I did something wrong with the update or if it just needs maintainer approval, but any help would be much appreciated!

dg0yt
dg0yt reviewed Nov 25, 2023
View reviewed changes
ports/poco/vcpkg.json Outdated
@@ -1,6 +1,6 @@
{
"name": "poco",
"version": "1.12.5",
"version": "1.12.5p1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't this literal here, and changing the version scheme also isn't a good idea.
It might be appropriate to use 1.12.5.1 here if POCO will never use it.
But then the REF in the portfile must be modified to use 1.12.5p1 literally.

(Disclaimer: I'm only a community member.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @dg0yt!

@mltucker mltucker force-pushed the master branch 2 times, most recently from e26a6f4 to 691249f Compare November 26, 2023 04:03
@mltucker mltucker marked this pull request as ready for review November 26, 2023 04:05
@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 27, 2023
MonicaLiu0311
MonicaLiu0311 reviewed Nov 27, 2023
View reviewed changes
ports/poco/portfile.cmake Outdated
@@ -2,7 +2,7 @@ vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO pocoproject/poco
REF "poco-${VERSION}-release"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
REF "poco-${VERSION}-release"
REF "poco-1.12.5p1-release"

Please modify to resolve the following errors:

Downloading https://vcpkgassetcacheeastasia.blob.core.windows.net/cache/9cf885f67d87b86d3d5337aa2a3247a5828e071bba04304dfb79f7e00d94cd245e5def5191400a5753eebe0611b7f120c470cb0e0ab9b120f1d8b5f202d7d3d7?*** SECRET ***
Downloading https://github.com/pocoproject/poco/archive/poco-1.12.5.1-release.tar.gz
error: Failed to download from mirror set
error: https://vcpkgassetcacheeastasia.blob.core.windows.net/cache/9cf885f67d87b86d3d5337aa2a3247a5828e071bba04304dfb79f7e00d94cd245e5def5191400a5753eebe0611b7f120c470cb0e0ab9b120f1d8b5f202d7d3d7?*** SECRET ***: failed: status code 404
error: https://github.com/pocoproject/poco/archive/poco-1.12.5.1-release.tar.gz: failed: status code 404

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MonicaLiu0311!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I meant by

the REF in the portfile must be modified to use 1.12.5p1 literally.

Remember to mark the PR as "Ready for review" again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dg0yt ahh, yes makes sense now. Thanks again.

@MonicaLiu0311
Copy link
Contributor

Note: I will be converting your PR to draft status. When you're ready, please revert to "ready for review".

@MonicaLiu0311 MonicaLiu0311 marked this pull request as draft November 27, 2023 02:19
@mltucker mltucker marked this pull request as ready for review November 27, 2023 07:00
@MonicaLiu0311
Copy link
Contributor

All features are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

The usage test passed on x64-windows (header files found):

The package poco is compatible with built-in CMake targets:

    find_package(Poco REQUIRED [COMPONENTS <libs>...])
    target_link_libraries(main PRIVATE Poco::<libs>)

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Nov 28, 2023
@vicroms vicroms merged commit 8f21bde into microsoft:master Nov 29, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@MonicaLiu0311 MonicaLiu0311 MonicaLiu0311 approved these changes

Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mltucker @MonicaLiu0311 @dg0yt @vicroms