[darknet] Fix dependence cuda

[FrankXie05]

Fix #33355

• Changes comply with the maintainer guide
• SHA512s are updated for each updated download
• The "supports" clause reflects platforms that may be fixed by this new version
• Any fixed CI baseline entries are removed from that file.
• Any patches that are no longer applied are deleted from the port's directory.
• The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
• Only one version is added to each modified port's versions file.

[dg0yt]

With the feature dependencies added, isn't the patch obsolete now?

[dg0yt]

Pointless. The block starts with if(ENABLE_OPENCV).
And given REQUIRED, ENABLE_OPENCV implies OpenCV_FOUND.
(However, NOT ENABLE_OPENCV doesn't necessarily imply NOT OpenCV_FOUND.)

[cenit]

being the author of the original CMakeLists.txt, can you please tell me the errors and the logic behind your fixes?
So that we can properly fix also upstream... :)

[FrankXie05]

@cenit Thank you for your reply,
The core problem is:
Condition if(OpenCV_FOUND AND OpenCV_VERSION VERSION_GREATER "3.0" AND BUILD_USELIB_TRACK) cannot be satisfied.
https://github.com/AlexeyAB/darknet/blob/27b37bf1033c1524121850f3705044f50c0c1b8c/CMakeLists.txt#L468

Because OpenCV_FOUND cannot be provided and found.

[dg0yt]

Because OpenCV_FOUND cannot be provided and found.

There already is find_package(OpenCV REQUIRED).

AFAIU there is an issue with finding CUDA. Which at least has the effect of turning off BUILD_USELIB_TRACK.

[cenit]

Because OpenCV_FOUND cannot be provided and found.

There already is find_package(OpenCV REQUIRED).

AFAIU there is an issue with finding CUDA. Which at least has the effect of turning off BUILD_USELIB_TRACK.

dg0yt is right.
The condition is mandatory for uselib_track to be built, otherwise you are trying to build something without mandatory dependencies. It really needs an opencv newer than 3.0 and it needs also some verifications on CUDA, which are performed before and that might turn off the "BUILD_USELIB_TRACK"

[cenit]

the pr is still broken from my point of view.
The feature opencv-cuda is not really related to darknet[cuda,cudnn], so there is no reason to enable it if the user only wanted a darknet with an opencv-cuda enabled backend... Is it fixing now any kind of problem? Again, may I know what was the problem?

[FrankXie05]

@cenit
./vcpkg install darknet[opencv-cuda]

CMake Error at scripts/cmake/vcpkg_copy_tools.cmake:36 (message):
Couldn't find tool "uselib_track":

  "E:/github/vcpkg/packages/darknet_x64-windows/bin/uselib_track.exe" does not exist

[cenit]

so the error is just at the copy tool clause: to find the uselib_track tool built, you need to have selected opencv-cuda feature AND cuda+cudnn feature, not just opencv-cuda feature.
I think that's the only fix to do

[FrankXie05]

@cenit
I think we only need to add cuda. Do we need cudnn?

[FrankXie05]

Sorry. For the editing of your comments. I seem to have made a mistake in my operation. 😅

[FrankXie05]

so the error is just at the copy tool clause: to find the uselib_track tool built, you need to have selected opencv-cuda feature AND cuda+cudnn feature, not just opencv-cuda feature.
I think that's the only fix to do

Judging from the code logic of CMakeLists.txt, it is just the call of macro ENABLE_CUDA that is missing.
Feature darknet[opencv-cuda, opencv3-cuda] only relies on darknet[cuda].

[cenit]

without the cuda feature of course you cannot have enable_cuda on!
the error is on the vcpkg port, which is expecting the uselib_track tool when only the opencv-cuda is enabled. But that feature does not enable cuda in darknet, just in its opencv dependency. To enable cuda in darknet you have to request the cuda feature. And uselib_track will be built when both opencv-cuda and cuda features are enabled!

[cenit]

but but... the result should have been different, as i tried many times to explain... uselib_track should have been copied as a tool when both feature were enabled, otherwise it does not exist by definition!
The result now is illogic, because you made one feature depending on the other (which makes one of the two superfluous...)
@vicroms

[FrankXie05]

However, this condition is not enough to open BUILD_USELIB_TRACK. (missing ENABLE_CUDA) .
("opencv-cuda" IN_LIST FEATURES OR "opencv3-cuda" IN_LIST FEATURES)
https://github.com/AlexeyAB/darknet/blob/27b37bf1033c1524121850f3705044f50c0c1b8c/CMakeLists.txt#L326

[cenit]

@FrankXie05 I wrote that file (the cmakelists you're linking)...
Maybe I am not able to explain clearly enough! But the corrections should have been on the portfile, at L44: the uselib_track exists only when "both" cuda AND opencv-cuda features are selected.