Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vxl] Fix missing header files #35875

Merged
merged 2 commits into from
Dec 28, 2023
Merged

[vxl] Fix missing header files #35875

merged 2 commits into from
Dec 28, 2023

Conversation

jimwang118
Copy link
Contributor

Fixes #32397

/mnt/vcpkg/buildtrees/vxl/src/4a7bd1d8ee-ec810ed456/core/vnl/vnl_bignum.cxx: In member function ‘vnl_bignum::operator float() const’:
/mnt/vcpkg/buildtrees/vxl/src/4a7bd1d8ee-ec810ed456/core/vnl/vnl_bignum.cxx:716:37: error: ‘numeric_limits’ is not a member of ‘std’
  716 |   if (this->is_infinity()) f = std::numeric_limits<float>::infinity();

The function cannot be found due to the lack of header files. Add the corresponding header files.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Compile test pass with following triplets:

x64-linux

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Dec 26, 2023
@jimwang118 jimwang118 marked this pull request as ready for review December 26, 2023 09:10
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Dec 27, 2023
@vicroms vicroms merged commit 76d9952 into microsoft:master Dec 28, 2023
15 checks passed
@JonLiu1993 JonLiu1993 removed the category:port-bug The issue is with a library, which is something the port should already support label Jan 4, 2024
@jimwang118 jimwang118 deleted the fixvxl branch January 4, 2024 09:11
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
* add header file

* update version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vxl] Build failure
3 participants