Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pcl] update to version 1.14.0 #36032

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

mvieth
Copy link
Contributor

@mvieth mvieth commented Jan 4, 2024

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version no change
  • Any fixed CI baseline entries are removed from that file. no change
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Updated add-gcc-version-check.patch and fit-numeric-literals-flag.patch to work with PCL 1.14.0.
Modified fix-clang-cl.patch because some of the changes are already included in PCL 1.14.0.
Removed devendor-zlib.patch because it is included in PCL 1.14.0 ( PointCloudLibrary/pcl#5684 )
Deleted further patches which are unused since vcpkg update to PCL 1.13.1.

@Adela0814 Adela0814 self-assigned this Jan 5, 2024
@Adela0814 Adela0814 added the category:port-update The issue is with a library, which is requesting update new revision label Jan 5, 2024
@mvieth mvieth marked this pull request as ready for review January 5, 2024 18:37
@Adela0814
Copy link
Contributor

@mvieth I encountered the following errors while testing all features.
Repro steps:
.\vcpkg.exe install pcl[*]:x64-windows
Error message:

        Line 19194: E:\5\vcpkg\buildtrees\pcl\src\pcl-1.14.0-55b936601d.clean\gpu\kinfu\src\cuda\marching_cubes.cu(61): note: see reference to function template instantiation 'cudaError_t cudaBindTexture<int,1,cudaReadModeElementType>(size_t *,const texture<int,1,cudaReadModeElementType> &,const void *,const cudaChannelFormatDesc &,size_t)' being compiled
	Line 19196: E:\5\vcpkg\buildtrees\pcl\src\pcl-1.14.0-55b936601d.clean\gpu\kinfu\src\cuda\marching_cubes.cu(68): note: see reference to function template instantiation 'cudaError_t cudaUnbindTexture<int,1,cudaReadModeElementType>(const texture<int,1,cudaReadModeElementType> &)' being compiled
	Line 19254: E:\5\vcpkg\buildtrees\pcl\src\pcl-1.14.0-55b936601d.clean\gpu\segmentation\src\extract_clusters.cpp(50): error C2375: 'pcl::detail::economical_download': redefinition; different linkage
	Line 19533: E:\5\vcpkg\buildtrees\pcl\src\pcl-1.14.0-55b936601d.clean\gpu\kinfu_large_scale\src\cuda\marching_cubes.cu(62): note: see reference to function template instantiation 'cudaError_t cudaBindTexture<int,1,cudaReadModeElementType>(size_t *,const texture<int,1,cudaReadModeElementType> &,const void *,const cudaChannelFormatDesc &,size_t)' being compiled
	Line 19536: E:\5\vcpkg\buildtrees\pcl\src\pcl-1.14.0-55b936601d.clean\gpu\kinfu_large_scale\src\cuda\marching_cubes.cu(69): note: see reference to function template instantiation 'cudaError_t cudaUnbindTexture<int,1,cudaReadModeElementType>(const texture<int,1,cudaReadModeElementType> &)' being compiled

@Adela0814 Adela0814 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Jan 8, 2024
@mvieth
Copy link
Contributor Author

mvieth commented Jan 8, 2024

@Adela0814 Thank you, I only tested with Linux so far, where everything passed. Could you tell me which CUDA version you used?

@Adela0814
Copy link
Contributor

@Adela0814 Thank you, I only tested with Linux so far, where everything passed. Could you tell me which CUDA version you used?

11.6.

@mvieth
Copy link
Contributor Author

mvieth commented Jan 9, 2024

@Adela0814 With the new patch I added, .\vcpkg.exe install pcl[*]:x64-windows installs successfully

@Adela0814 Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Jan 10, 2024
@JavierMatosD JavierMatosD merged commit 8a5830e into microsoft:master Jan 11, 2024
15 checks passed
@mvieth mvieth deleted the update-pcl-1.14.0 branch January 11, 2024 16:18
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
* [pcl] update to version 1.14.0

* Add new patch
TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
* [pcl] update to version 1.14.0

* Add new patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants